Date: Fri, 24 Jun 2011 11:47:56 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223488 - head/lib/libstand Message-ID: <20110624114756.534b333d@kan.dnsalias.net> In-Reply-To: <201106240350.p5O3otfc028955@svn.freebsd.org> References: <201106240350.p5O3otfc028955@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/P6s3h.qyAvJ9TIu4VyWd=no
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
On Fri, 24 Jun 2011 03:50:55 +0000 (UTC)
Craig Rodrigues <rodrigc@FreeBSD.org> wrote:
Hi,
> + if (d->xid !=3D 1) {
> + return (-1);
> + }
this is distinctly NOT what I sent to you and would rather not take
credit for consequences. What you are doing here is not dropping the
packet, you are returning error from read and with errno in unknown
state on top of that. Why did this have to change and why there is no
mention of that in the commit message?
--=20
Alexander Kabaev
--Sig_/P6s3h.qyAvJ9TIu4VyWd=no
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)
iD8DBQFOBLGxQ6z1jMm+XZYRAtd6AJ9e3t7N3KaVLpHeDsmJRudG8iHoLACeLIuH
4+aeSV34KqOm/Lam/B+ubsA=
=WP1T
-----END PGP SIGNATURE-----
--Sig_/P6s3h.qyAvJ9TIu4VyWd=no--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110624114756.534b333d>