Date: Tue, 10 Oct 2023 22:26:17 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 6b2a6e9cb09b - main - nvme: Remove stale comment Message-ID: <202310102226.39AMQHc0085456@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=6b2a6e9cb09b1250b2a4042e0bfc60ae43835fc7 commit 6b2a6e9cb09b1250b2a4042e0bfc60ae43835fc7 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-10-10 17:13:07 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-10-10 22:13:56 +0000 nvme: Remove stale comment After da8324a9258f, the pre/post hooks are gone. So remove a coment about why we don't call them in this case. Sponsored by: Netflix Reviewed by: chuck, jhb Differential Revision: https://reviews.freebsd.org/D42050 --- sys/dev/nvme/nvme_ctrlr.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index e5a548b6f6b2..90cd0b64a980 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -1133,11 +1133,6 @@ nvme_ctrlr_start_config_hook(void *arg) TSENTER(); - /* - * Don't call pre/post reset here. We've not yet created the qpairs, - * haven't setup the ISRs, so there's no need to 'drain' them or - * 'exclude' them. - */ if (nvme_ctrlr_hw_reset(ctrlr) != 0) { fail: nvme_ctrlr_fail(ctrlr);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202310102226.39AMQHc0085456>