Date: Sun, 24 Jun 2007 18:12:27 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Joe Marcus Clarke <marcus@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/cairo Makefile ports/graphics/cairo/files patch-git Message-ID: <1182701547.14601.6.camel@ikaros.oook.cz> In-Reply-To: <20070624150141.GA85107@FreeBSD.org> References: <200706230010.l5N0AYKJ055836@repoman.freebsd.org> <20070624150141.GA85107@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
Alexey Dokuchaev píše v ne 24. 06. 2007 v 15:01 +0000:
> On Sat, Jun 23, 2007 at 12:10:34AM +0000, Joe Marcus Clarke wrote:
> > marcus 2007-06-23 00:10:34 UTC
> > Add a patch from Freedesktop git to fix a crash with OpenOffice
> > applications.
> >
> > Obtained from: Freedesktop git
> >
> > Revision Changes Path
> > 1.28 +1 -1 ports/graphics/cairo/Makefile
> > 1.1 +72 -0 ports/graphics/cairo/files/patch-git (new)
>
> It's usually a better practice to name such patches like
> `patch-ooo-crash-fix' instead. Mere `-git' suffix does not tell much
> about what is this patch for.
Commit log says what the patch is for.
Which is kinda better than 50% of the patches in the tree, which have
both meaningless name and meaningless commit log. *g
--
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
I am a shrubber. My name is Roger the Shrubber. I arrange, design and
sell shrubberies.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)
iD8DBQBGfpfnntdYP8FOsoIRArE9AJsHYSj+Gu7ogsLy2/BHMfs1LLl/uACgrRdh
vPvEHWZ0WPj2XudicH9HWLo=
=t1z2
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1182701547.14601.6.camel>