Date: Fri, 14 Apr 2023 08:40:09 +0900 From: Pawel Jakub Dawidek <pawel@dawidek.net> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Mateusz Guzik <mjguzik@gmail.com>, Mark Millard <marklmi@yahoo.com>, vishwin@freebsd.org, dev-commits-src-main@freebsd.org, Current FreeBSD <freebsd-current@freebsd.org>, Shawn Webb <shawn.webb@hardenedbsd.org> Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 Message-ID: <5e67bfbc-1e9c-432b-ac03-61839bd47e20@dawidek.net> In-Reply-To: <060e8793-cca7-9301-57ac-9c73a187db3f@dawidek.net> References: <20230413071032.18BFF31F@slippy.cwsent.com> <D0D9BD06-C321-454C-A038-C55C63E0DD6B@dawidek.net> <20230413063321.60344b1f@cschubert.com> <CAGudoHG3rCx93gyJTmzTBnSe4fQ9=m4mBESWbKVWtAGRxen_4w@mail.gmail.com> <20230413135635.6B62F354@slippy.cwsent.com> <20230413140504.nnm23cjjv65mwzjr@mutt-hbsd> <060e8793-cca7-9301-57ac-9c73a187db3f@dawidek.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/14/23 07:36, Pawel Jakub Dawidek wrote: > On 4/13/23 23:05, Shawn Webb wrote: >> I've learned over the years downstream that it's not really my place >> to tell upstream what to do or how to do it. However, I think given >> the seriousness of this, upstream might do well to revert the commit >> until a solid fix is in place. Upstream might want to consider the >> impacts this is having not just with downstream projects, but also >> regular users. >> >> Really bad timing to have a lot of new tax documentation that I really >> don't want to lose. I'd really like to have an up-to-date, security >> patched OS, but I guess I'll stay behind so that I don't risk losing >> critical financial documentation. > > Shawn, > > I'm working on a patch to safely revert this that would also work for > people who already upgraded their pools. > > I'm sorry for this mess. > Here is the change that reverts most of the modifications and disables cloning new blocks. It does retain ability to free existing cloned blocks and keeps block_cloning feature around, so upgraded pools can be imported and existing cloned blocks freed. It does not handle replaying ZIL with block-cloning logs, so make sure you import pools that were cleanly exported. I'd appreciate if someone who can reproduce those corruptions could try it. https://github.com/pjd/openzfs/commit/f2cfbcf76a733c44e25cba8c649162ef68047103 Thank you guys for your help! -- Pawel Jakub Dawidek
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5e67bfbc-1e9c-432b-ac03-61839bd47e20>