Date: Tue, 31 Jul 2012 12:39:07 +0700 From: Max Khon <fjoe@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r238775 - stable/8/sys/dev/puc Message-ID: <CADe0-4n1Ug4BTz01_5dYa4Mh0X2UjHhC7e=qCmF8W1KmF87xuA@mail.gmail.com> In-Reply-To: <201207301132.34524.jhb@freebsd.org> References: <201207251742.q6PHgvDj083177@svn.freebsd.org> <201207301132.34524.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John, On Mon, Jul 30, 2012 at 10:32 PM, John Baldwin <jhb@freebsd.org> wrote: > On Wednesday, July 25, 2012 1:42:57 pm Max Khon wrote: >> Author: fjoe >> Date: Wed Jul 25 17:42:57 2012 >> New Revision: 238775 >> URL: http://svn.freebsd.org/changeset/base/238775 >> >> Log: >> MFC: r227457, r237350, r237357 >> >> Add support for the following Moxa PCIe multiport serial boards: >> - CP102E >> - CP102EL >> - CP104EL-A >> - CP104JU >> - CP114EL >> - CP118EL-A >> - CP168EL-A > > You ignored the comments from Marcel when you committed this to HEAD it seems. > You need to revert d_ofs back to a int8_t and add a config_function for these > adapters instead that use an offset of 0x200. Well, I did not ignore comments from Marcel - his e-mail got lost in my inbox. Sorry about that. I was notified about the issue off the list several days ago and fixed it today. Max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADe0-4n1Ug4BTz01_5dYa4Mh0X2UjHhC7e=qCmF8W1KmF87xuA>