Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Feb 2025 20:55:16 GMT
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 2a704e9ca7e9 - stable/14 - TCP BBR: remove dead code
Message-ID:  <202502052055.515KtGum004102@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=2a704e9ca7e940d960ac493d015af59f0326b9b8

commit 2a704e9ca7e940d960ac493d015af59f0326b9b8
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2025-01-06 19:40:33 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-02-05 09:55:36 +0000

    TCP BBR: remove dead code
    
    bw is unsigned and not zero. So it cannot be smaller than 1.
    No functional change intended.
    
    Reviewed by:            rrs, cc
    CID:                    1523791
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D48323
    
    (cherry picked from commit c28fefe1dc44b69743dd18d038440da38a2867a7)
---
 sys/netinet/tcp_stacks/bbr.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c
index 6c6bc5d1532f..73751e984125 100644
--- a/sys/netinet/tcp_stacks/bbr.c
+++ b/sys/netinet/tcp_stacks/bbr.c
@@ -2992,9 +2992,6 @@ use_initial_window:
 		/* We should not be at 0, go to the initial window then  */
 		goto use_initial_window;
 	}
-	if (bw < 1)
-		/* Probably should panic */
-		bw = 1;
 	if (bw < min_bw)
 		bw = min_bw;
 	return (bw);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502052055.515KtGum004102>