Date: Mon, 04 Feb 2008 18:11:39 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Daniel Eischen <deischen@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, threads@freebsd.org Subject: Re: cvs commit: src/include pthread_np.h src/lib/libthr pthread.map src/lib/libthr/thread thr_mutex.c Message-ID: <86ejbsd4tw.fsf@ds4.des.no> In-Reply-To: <Pine.GSO.4.64.0802041123210.13899@sea.ntplx.net> (Daniel Eischen's message of "Mon\, 4 Feb 2008 11\:31\:09 -0500 \(EST\)") References: <200802032238.m13McAbf065324@repoman.freebsd.org> <86d4rdgehd.fsf@ds4.des.no> <Pine.GSO.4.64.0802041042370.13743@sea.ntplx.net> <868x20elw0.fsf@ds4.des.no> <Pine.GSO.4.64.0802041123210.13899@sea.ntplx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Daniel Eischen <deischen@freebsd.org> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > Daniel Eischen <deischen@freebsd.org> writes: > > > If you want to know if the current thread has it locked, it should be > > > called pthread_mutex_isowned_np(). > > I don't see why one would be more correct than the other... > Because it is more obvious that _isowned() is for the current thread > than _islocked(). As you can tell by my previous (incorrect) > assumption. > > There is prior art for this outside of FreeBSD. Solaris has > mutex_owned() as part of their kernel mutex API. I would suggest > using pthread_mutex_owned_np(). Hmm, even FreeBSD has mtx_owned() :-) OK, so the next question is whether this reqires a repo-copy (or a repo-move), or if I can just cvs rm + cvs add (both the implementation and the regression test) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ejbsd4tw.fsf>