Date: Mon, 12 Nov 2018 19:34:23 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Max Brazhnikov <makc@freebsd.org> Cc: Jan Beich <jbeich@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, henry.hu.sh@gmail.com Subject: Re: svn commit: r484686 - head/net-im/telegram-desktop Message-ID: <20181112183423.xmp67tjjghceot75@atuin.in.mat.cc> In-Reply-To: <4618826.YNO7O01DYZ@mercury.ph.man.ac.uk> References: <201811111145.wABBjKcf027649@repo.freebsd.org> <5zx3-zver-wny@FreeBSD.org> <4618826.YNO7O01DYZ@mercury.ph.man.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
--2qtltp4qbttzu2l4
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Nov 11, 2018 at 11:59:48AM +0000, Max Brazhnikov wrote:
> On =D0=B2=D0=BE=D1=81=D0=BA=D1=80=D0=B5=D1=81=D0=B5=D0=BD=D1=8C=D0=B5, 11=
=D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2018 =D0=B3. 11:49:16 UTC Jan Beich w=
rote:
> > Max Brazhnikov <makc@FreeBSD.org> writes:
> > > @@ -82,6 +82,7 @@ post-patch:
> > > ${FILESDIR}/gyp-patches | \
> > > ${PATCH} -z .bak -s)
> > > =09
> > > @${ECHO} "#define FREEBSD_QT_PLUGINDIR \"${QT_PLUGINDIR}\"" >
> > > ${WRKSRC}/Telegram/SourceFiles/FREEBSD_QT_PLUGINDIR.h>=20
> > > + ${SED} -i -e "/Icon=3D/s|telegram|${PORTNAME}|"
> > > ${WRKSRC}/lib/xdg/telegramdesktop.desktop
> > Why ${SED} -i instead of ${REINPLACE_CMD}?
>=20
> For sake of consistency with the rest of the file. I leave it to maintain=
er.
The reason we have committers and not a simple script that commits every
patch that applies in is so that people who know better (the committers,
you, Jan, me) fix submissions from maintainers to match our policies and
way of doing things.
Now, the Makefile is consistenly bad, that is for sure.
--=20
Mathieu Arnold
--2qtltp4qbttzu2l4
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlvpx69fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkj2ag//a08ODOKL9VtoblJurGkNTvcFT/V+KH1046eqcyge9t+jk7klHwMJoVM7
lPz9Tshgiq+FO538a0pNERqqQNyIsNETsjdru7FFNuJyh7fvZ46aU0j0oEKlmE8q
rGaSm5S6lyMeAOYnnP5WWHJ0QBuCW/DkwF5lxTB7/dxMwJY3PjvMPrijCrwdKA67
5RI7ydhmDMfd2X1wxht4PnDNYT/sxDYQ8wLrfPvj6D+48cXiqlVyOCB8aYhX/hQP
0kmZtDJ44nG8QSwBSyOQCCLe5cCPFN6afFulM722rgTvx+pVo7gRgiUxK3KaTKqg
dci8FpOJxOwIDtlKVGfg6j3KGMf7adCsVNfVILWPClu9oAOs9wFmBlteFU2wqTGS
4FjJmICrKsQsJtL1/qBVWqMzbRdV0EPPtfn5w5nzueDo5SUHkw+GzAAGR0CqlMYo
62tSYoQ5z6NdlIUOjNWdf9AAt7n1DiNlOK16y+F/NdKAkij9eIPwWaqVONU9IHEY
eG4lCYIyvAf4KiAk3O6x/P7YCOPfWVCKOFeWaVqgKSCkMXC0kF0VI+AZmwgpwRSU
QQyKwSCOeem9VrBzRnJgf7Ldeg3TUDauzxx+U3qOTB48TRBfVVSpWdEGqLXg5gEo
opKfwwTXglOe647fXX2SzQEbpXMhL2Z84H7902clkOhurmeY1jM=
=IvLE
-----END PGP SIGNATURE-----
--2qtltp4qbttzu2l4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181112183423.xmp67tjjghceot75>