Date: Fri, 31 May 2024 21:39:47 +0300 From: Aleksandr Fedorov <wigneddoom@yandex.ru> To: Brooks Davis <brooks@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 9b8db66402e9 - main - netgraph: provide separate malloc type for nodes that are missing it Message-ID: <543841717180705@mail.yandex.ru> References: <202405311620.44VGK2xX033356@gitrepo.freebsd.org> <ZloQ5HpJa27AWVP4@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
<div><div>I think we should remove this option altogether - NG_SEPARATE_MALLOC.</div><div> </div><div>Now, 90+% of nodes declare their own malloc(9) type.</div><div> </div><div>For example, look at https://github.com/freebsd/freebsd-src/blob/main/sys/netgraph/ng_bridge.c#L81</div><div> </div><div>Some people want to see this through vmstat.</div></div><div> </div><div> </div><div>31.05.2024, 21:03, "Brooks Davis" <brooks@freebsd.org>:</div><div><br />On Fri, May 31, 2024 at 04:20:02PM +0000, Gleb Smirnoff wrote:<br /> The branch main has been updated by glebius:<br /> <br /> URL: https://cgit.FreeBSD.org/src/commit/?id=9b8db66402e94919ab47fc2d69863968e49e305a<br /> <br /> commit 9b8db66402e94919ab47fc2d69863968e49e305a<br /> Author: Dmitry Lukhtionov <dmitryluhtionov@gmail.com><br /> AuthorDate: 2024-05-31 16:19:54 +0000<br /> Commit: Gleb Smirnoff <glebius@FreeBSD.org><br /> CommitDate: 2024-05-31 16:19:54 +0000<br /> <br /> netgraph: provide separate malloc type for nodes that are missing it<br /> <br /> The kernel option NG_SEPARATE_MALLOC helps to debug memory leaks in<br /> netgraph(4). Several nodes were missing the support.<br /><br />I realize this commit didn't create the option, but is there really<br />enough of a cost to having multiple malloc types to justify an option at<br />all?<br /><br />-- Brooks</div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?543841717180705>