Date: Thu, 11 Jul 2013 22:26:33 +0200 From: Tijl Coosemans <tijl@coosemans.org> To: David Chisnall <theraven@FreeBSD.org>, Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r253215 - head/lib/msun/src Message-ID: <51DF14F9.50001@coosemans.org> In-Reply-To: <51DF0FA5.4050106@coosemans.org> References: <201307111741.r6BHf5gQ060844@svn.freebsd.org> <51DEFEF7.4080709@coosemans.org> <7D521907-4802-4141-9A5E-40EB157A5AEF@FreeBSD.org> <51DF0FA5.4050106@coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PCBEHFJOSCTIFNHTVUBT Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-07-11 22:03, Tijl Coosemans wrote: > On 2013-07-11 21:36, David Chisnall wrote: >> On 11 Jul 2013, at 19:52, Tijl Coosemans <tijl@coosemans.org> wrote: >>>> @@ -227,8 +250,6 @@ double expm1(double); >>>> double fma(double, double, double); >>>> double hypot(double, double); >>>> int ilogb(double) __pure2; >>>> -int (isinf)(double) __pure2; >>>> -int (isnan)(double) __pure2; >>> >>> I think they should stay for the C90 case. >> >> That would completely defeat the point of this entire exercise and be >> redundant unless we aim to support a compiler that only supports C90 >> and no GNU extensions, in which case you'll hit errors in cdefs.h, >> long before you get to this point in an include. >=20 > isnan(double) is part of SUSv2. It should be visible when compiling wit= h > -D_XOPEN_SOURCE=3D500. I think you need something like this: >=20 > #if (__BSD_VISIBLE || __XSI_VISIBLE <=3D 500) && __ISO_C_VISIBLE < 1999= > int isinf(double) __pure2; > int isnan(double) __pure2; > #endif Actually this: #if (__BSD_VISIBLE || (defined(__XSI_VISIBLE) && __XSI_VISIBLE <=3D 500))= && __ISO_C_VISIBLE < 1999 ------enig2PCBEHFJOSCTIFNHTVUBT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iF4EAREIAAYFAlHfFP4ACgkQfoCS2CCgtitdoAD+OXfe70zo9LnLZ7pWOL3fWj2h e4JB/MtzTPBIAjgV6uIA/ilsgIqqgBMo3Ml/9qXL02hXpFFNXG477yXNlNJr3RGW =xmqp -----END PGP SIGNATURE----- ------enig2PCBEHFJOSCTIFNHTVUBT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51DF14F9.50001>