Date: Tue, 9 Jun 1998 13:47:51 +0900 (JST) From: Michael Hancock <michaelh@cet.co.jp> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-sys@FreeBSD.ORG, julian@FreeBSD.ORG Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c Message-ID: <Pine.SV4.3.95.980609133809.16096A-100000@parkplace.cet.co.jp> In-Reply-To: <199806090041.KAA11579@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 9 Jun 1998, Bruce Evans wrote: > It actually broke the (doingdirectory && newparent) case, as > shown in the example. D2's link count became -1 (if Y was the > only subdirectory in it to begin with), so it could not be > removed and it took an fsck to fix the error. That was a tough one, good job! While we're looking at rename, I should note my comment ... /* XXX - Temporarily preserve previous rele behavior */ is wrong. The code does belong there and ... /* Cleanup after VREF and relookup */ would probably be more appropriate. rename was a little hard to follow because the auto vp variables are reused and can possibly refer to entirely different things and it was expecially difficult to track exactly who was getting rele'd on all the exits. I'll fix this when I get my head above water and can start working on this again.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.SV4.3.95.980609133809.16096A-100000>