Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Feb 2025 22:50:04 GMT
From:      Cheng Cui <cc@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 6156da866e7d - main - cc_cubic: remove redundant calls of tcp_fixed_maxseg()
Message-ID:  <202502122250.51CMo4ps019270@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by cc:

URL: https://cgit.FreeBSD.org/src/commit/?id=6156da866e7db8dab36b96ac4f4e38f75e41200d

commit 6156da866e7db8dab36b96ac4f4e38f75e41200d
Author:     Cheng Cui <cc@FreeBSD.org>
AuthorDate: 2025-02-12 16:41:08 +0000
Commit:     Cheng Cui <cc@FreeBSD.org>
CommitDate: 2025-02-12 22:49:21 +0000

    cc_cubic: remove redundant calls of tcp_fixed_maxseg()
    
    Summary: No functional change intended.
    
    Reviewed by: rscheff, tuexen
    
    Subscribers: imp, melifaro, glebius
    
    Differential Revision: https://reviews.freebsd.org/D48967
---
 sys/netinet/cc/cc_cubic.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sys/netinet/cc/cc_cubic.c b/sys/netinet/cc/cc_cubic.c
index 3b134082a59b..ae1561ca54c3 100644
--- a/sys/netinet/cc/cc_cubic.c
+++ b/sys/netinet/cc/cc_cubic.c
@@ -298,7 +298,7 @@ cubic_ack_received(struct cc_var *ccv, ccsignal_t type)
 			W_cubic = cubic_cwnd(usecs_since_epoch +
 					     cubic_data->mean_rtt_usecs,
 					     cubic_data->W_max,
-					     tcp_fixed_maxseg(ccv->tp),
+					     mss,
 					     cubic_data->K);
 
 			if (W_cubic < W_est) {
@@ -328,8 +328,7 @@ cubic_ack_received(struct cc_var *ccv, ccsignal_t type)
 			if (((cubic_data->flags & CUBICFLAG_CONG_EVENT) == 0) &&
 			    cubic_data->W_max < CCV(ccv, snd_cwnd)) {
 				cubic_data->W_max = CCV(ccv, snd_cwnd);
-				cubic_data->K = cubic_k(cubic_data->W_max /
-				    tcp_fixed_maxseg(ccv->tp));
+				cubic_data->K = cubic_k(cubic_data->W_max / mss);
 			}
 		}
 	} else if (type == CC_ACK && !IN_RECOVERY(CCV(ccv, t_flags)) &&



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502122250.51CMo4ps019270>