Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Jun 2002 12:28:38 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Chad David <davidc@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject:   Re: cvs commit: src/sys/kern kern_sig.c
Message-ID:  <20020607121232.Q13645-100000@gamplex.bde.org>
In-Reply-To: <200206061912.g56JCiX08025@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> davidc      2002/06/06 12:12:44 PDT
>
>   Modified files:
>     sys/kern             kern_sig.c
>   Log:
>   s/!SIGNOTEMPY/SIGISEMPTY/
>
>   Reviewed by: marcel, jhb, alfred

One or both of these shouldn't exist.  SIGISEMPTY was unused.  SIGNOTEMPTY
was used a whole 6 times in /sys and 0 times in libc.  SIGISEMPTY is
just a wrapper for __sigisempty, and __sigisempty could be named
sigisempty and used instead.  IIRC, the 2 layers of wrappers are mainly
to support dead and/or moot uses in <signal.h> and libc.  __sigisempty
needs to have 2 underscores if it is used in a standard header, but
it isn't used there.  libc could use the macros in <sys/signalvar.h>,
but doesn't.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020607121232.Q13645-100000>