Date: Tue, 24 Mar 2015 10:35:04 -0400 From: Allan Jude <allanjude@freebsd.org> To: "Ellis H. Wilson III" <ellisw@panasas.com>, freebsd-sysinstall@freebsd.org, kczekirda@FreeBSD.org Subject: Re: RFC: Patches to achieve bsdinstall script without dialogs Message-ID: <55117618.8020308@freebsd.org> In-Reply-To: <551172FC.1010508@panasas.com> References: <54EF7B40.2030706@panasas.com> <551172FC.1010508@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qx3DqjXqkCQnXdj1nes796Q7aIb5d7vpj Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2015-03-24 10:21, Ellis H. Wilson III wrote: > It's been about a month since I sent the below RFC. What is the best > way to facilitate discussion about this or move towards committing thes= e > changes to the bsdinstall tool? >=20 > Best, >=20 > ellis >=20 > On 02/26/15 15:00, Ellis H. Wilson III wrote: >> All, >> >> We use FreeBSD extensively here at Panasas, and in our day-to-day >> software development it behooves us to have an automatic way to spin u= p >> our various clients with fresh installs. Occasionally, one of these >> automated installs, which relies on the various components of >> bsdinstall, bails, locks up, or otherwise malfunctions. At that >> juncture, checking our console logs is our best/only recourse since >> these are head-less machines, but the existing code presumes (even in >> the case of scripted installs) dialog will render properly. This is >> typically not the case in our live console or console logs for a varie= ty >> of reasons, and this results in our engineers wading through a lot of >> dialog "curses-gunk" to find the relevant pieces of ascii that have ma= de >> their way through. >> >> Therefore, after positive discussion with Nathan Whitehorn about the >> general utility of having an ascii-only install option, we have >> implemented such and been running the attached patches for a few month= s >> with success here. These enable a somewhat friendlier ASCII output wh= en >> scripted installation is requested, without sacrificing (most of) the >> niceties of progress indication and the like. These also shouldn't >> impact non-scripted installation, which still utilize dialogs. With t= he >> ultimate hope of these being accepted upstream and benefiting others, = I >> am first presenting them here for your comment. These impact the >> following files, and are named accordingly: >> >> usr.sbin/bsdconfig/share/common.subr >> usr.sbin/bsdinstall/distextract/distextract.c >> usr.sbin/bsdinstall/scripts/checksum >> usr.sbin/bsdinstall/scripts/script >> usr.sbin/bsdinstall/partedit/partedit.c >> usr.sbin/bsdinstall/partedit/scripted.c >> usr.sbin/bsdinstall/partedit/partedit.h >> >> These are patched from 10.1 releng, as that is what we are running. I= f >> it will smooth the process towards upstreaming things, I can patch >> against a different set of sources (i.e., CURRENT), just let me know. >> >> Best, >> >> ellis >> >> >> _______________________________________________ >> freebsd-sysinstall@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall >> To unsubscribe, send any mail to >> "freebsd-sysinstall-unsubscribe@freebsd.org" >> >=20 > _______________________________________________ > freebsd-sysinstall@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall > To unsubscribe, send any mail to > "freebsd-sysinstall-unsubscribe@freebsd.org" These changes look ok to me. 2 main things: These would need to be based on HEAD not 10.1 in order to be committed And I wonder if they conflict with the FAI (Fast Automated Installer) patches, which I think also remove the dialogs --=20 Allan Jude --qx3DqjXqkCQnXdj1nes796Q7aIb5d7vpj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJVEXYYAAoJEJrBFpNRJZKf+FkP/R3GPWIpqZDVQHYiGsniTAqd gRqHTVMOSaMq/Pq3WQHtOVXFB26T9ghhmQl4FYyPbVDbrxXAU5IUwBrOaX+pzUtX aQHYD0XP7T+WyLsecYuAhGTEbyHYQ+GFajGSiFQOtbYuYI1jVrgpruLJ3bvX0NZL v8sCZ61at71LxjXvzxMT0EtCqdn8h7ex6IK4TSBbBwuzqHjcxOffMMxeiCZVCNJy x91s6OILj43QehwQeRmoVYvA1INNaU0OOtS+FMsv+1UcbZvv5wuawKSDj8hpE9oa 9STehlSA857Om21E5mCp1ke2mcHcWmA0v1yUfwXLAFmTkFNcmn06Bmqsi/Nsf8ag A/dN7qhW1L5RM+ExBC3EjSOuiouxTQo8IXEP3aPHs8XuCp8O0oDsaaTp7+BXbQ1C PI2pWXcGZP7Yyg0yCS2ArtxFEvyzun2agWN8NGY1JVicrAbg8RGNp4zCJMStIThS XsgjIHIwpxxk0313EBtoxt0WdiCYZ9Gt/Z4VuCiK8xZoXvN29W5W3RutLT4XUZ1X yMxCrLFTEmeMzUI/i0B8sByThJhEBK8YkWRr+CBdsibEOmaidhTM/BzK6J16lhUO AMZYUQMbzcwBviNYo5n15j/phXkrJnwQngrKotPNXHpb6i7iyRACZmLuClvWlOdc KHyKF4E13QbmjtX487lx =FxWR -----END PGP SIGNATURE----- --qx3DqjXqkCQnXdj1nes796Q7aIb5d7vpj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55117618.8020308>