Date: Mon, 8 Jan 2001 12:35:28 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Alfred Perlstein <bright@wintelcom.net> Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>, Bosko Milekic <bmilekic@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/musycc musycc.c Message-ID: <Pine.BSF.4.21.0101081230260.21487-100000@besplex.bde.org> In-Reply-To: <20010106141257.F15744@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 6 Jan 2001, Alfred Perlstein wrote: > not only that but we have one of my favorite bugs: > > while (csc->state != C_RUNNING) > tsleep(&csc->state, PZERO + PCATCH, "crun", hz/10); > > should have no PCATCH, or somehow deal with the signal instead of > looping forever. It also obfuscates ORing the PCATCH mask with the PZERO value. These bugs are repeated 15 times in the file (the value returned by tsleep() is not checked 17 times, but '|' is misspelled '+' only 15 times). > You're right, this file is pretty broken. :) Right :). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0101081230260.21487-100000>