Date: Tue, 11 Oct 2005 13:48:38 +0000 (UTC) From: Gleb Smirnoff <glebius@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netgraph ng_base.c Message-ID: <200510111348.j9BDmch3035019@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
glebius 2005-10-11 13:48:38 UTC
FreeBSD src repository
Modified files:
sys/netgraph ng_base.c
Log:
Fix a regression introduced in rev. 1.107. If an item once had a writer
semantics, and then was reused for next node, it still would be applied
as writer again.
To fix the regression the decision is made never to alter item->el_flags
after the item has been allocated. This requires checking for overrides
both in ng_dequeue() and in ng_snd_item().
Details:
- Caller of the ng_apply_item() knows what is the current access to
node and specifies it to ng_apply_item(). The latter drops the
given access after item has beem applied.
- ng_dequeue() needs to be supplied with int pointer, where it stores
the obtained access on node.
- Check for node/hook access overrides in ng_dequeue().
Revision Changes Path
1.113 +28 -22 src/sys/netgraph/ng_base.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510111348.j9BDmch3035019>