Date: Mon, 13 Jan 2003 14:35:40 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: rwatson@freebsd.org, hackers@freebsd.org Subject: RE: possible cpu_wait() / vm_waitproc() / MAC problem Message-ID: <XFMail.20030113143540.jhb@FreeBSD.org> In-Reply-To: <200301121010.h0CAAcr4081370@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12-Jan-2003 Matthew Dillon wrote: > While working on an MFC I noticed that sys/compat/svr4/svr4_misc.c > (in CURRENT) is calling cpu_wait() in svr4_sys_waitsys() instead of > vm_waitproc(). I believe it needs to call vm_waitproc(). Can anyone > say for sure? > > Also, in kern/kern_exit.c the wait code has this: > >#ifdef MAC > mac_destroy_proc(p) >#endif > > This appears to be missing from svr4_sys_waitsys() as well, also > in -current. Could someone confirm that? The svr4() wait code is just gross. We need to make it just pass a flag into wait1() IMO and have the svr4() implementation be a wrapper function. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030113143540.jhb>