Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 01 Mar 2018 12:59:47 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 226221] GH_TUPLE fails to deal with submodules inside a submodule
Message-ID:  <bug-226221-13-Pcp46URaOn@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-226221-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-226221-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226221

--- Comment #3 from commit-hook@freebsd.org ---
A commit references this bug:

Author: mat
Date: Thu Mar  1 12:58:53 UTC 2018
New revision: 463301
URL: https://svnweb.freebsd.org/changeset/ports/463301

Log:
  Fix a sub-submodule extraction problem with GH_SUBDIR.

  The problem is that GH_SUBDIR are handled in a somewhat random manner.  (=
The
  truth is that in the end of things, they end up being sorted by the group
name
  being used in the GH_TUPLE.)

  So if you have a submodule in bar/foo, and a sub-submodule in bar/foo/baz=
, it
  may happen that foo/bar/baz is handled before foo/bar and then things are
  messed up.

  This makes it so the GH_SUBDIR target handling is sorted first by the
  number of / in the path.  (So, bar/foo is always handled before
  bar/foo/baz.)

  PR:           226221
  Reported by:  ygy
  Sponsored by: Absolight
  Differential Revision:        https://reviews.freebsd.org/D14532

Changes:
  head/Mk/bsd.sites.mk

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-226221-13-Pcp46URaOn>