Date: Thu, 15 May 2014 16:50:03 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Oliver Pinter <oliver.pntr@gmail.com> Cc: arch@freebsd.org, gavin@freebsd.org, current@freebsd.org Subject: Re: [RFC] remove dead code from link_elf.c Message-ID: <20140515135003.GO74331@kib.kiev.ua> In-Reply-To: <CAPjTQNHTiEeSuf9y4Ddriq5Jj7L6yYNSqLujH2ni=XdUF5b-bg@mail.gmail.com> References: <CAPjTQNHTiEeSuf9y4Ddriq5Jj7L6yYNSqLujH2ni=XdUF5b-bg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--wmfuW8osuO2pi9jF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 15, 2014 at 03:36:51PM +0200, Oliver Pinter wrote: > Hi all! >=20 > I found that the SPARSE_MAPPING used only in sys/kern/link_elf.c file, > and no other place in kernel, nor in generated codes in /usr/obj/... >=20 > op@pandora-d opBSD.git> git grep -i SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING > sys/kern/link_elf.c:#ifdef SPARSE_MAPPING >=20 > I proposed to remove the old/dead codes. Patch attached. Tested on amd64. I agree that SPARSE_MAPPING could go away. But your testing is void, since link_elf.c is practically not used on amd64, which utilizes object file format for klds. --wmfuW8osuO2pi9jF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJTdMYKAAoJEJDCuSvBvK1Bu34P/ikDUz/j+RAq/Xk/dMznoHFx 27A7ym8WOOA4EN/GnCMdOgN7CJNCFeBBLNpBtfafISNJlxUbjJAJVFkxv3WuR591 tivRbG+0o26+3cSe8jF6CB4p7zfpG9qJ3qvXyo3RMeuWxZrBTKUk4JOy3rgK08+j WdBFybCHqyZnskCQcJTs9Hbifhnnb+La/YBkAfK1vP5h8UPrh7GUY8ES9gntn44R okKQKXvGGyZtM652Gb/ViIFtTdmjRW2VBjNyhPSXwcC3DTJOKFW/2sc7wJP6IiKg 8tOr2UvD01wqDJ9QTsMtIgaKXhHdiUbi7CRxoKE6JWamCat8YJ+K93x/HA1DXj8m ZqoIQ7mSVY/8LumnyOktN+9Qc1TYUVcEpQrbooAXELaHrRkwHUCkdcBTmipSr9LN C873CAakAP4+w4ZkWRWcewXAG0zZanYjBuvRVaLfgknT8ehzKFrBgOCTm/jd9hR2 jznuMcoQkXtKKXlHNIcprOZXb2rJvb/qndETqITo35oBcB2Fu9do3qMDsjKDuH9n aFFXHVB84EQxwZ6TGVexioegewkrRiIlsx3Cj/Su+RvMGocTDrgcLMEKBoI6eGzd FGOE74PbVN3ZVDLcGWbfeUIYuHEgg0gzIfeKsbqAu5c7SeUD/8/D1bMYK2mWVA35 fvBB5dgSfpK07RMs8dkb =uqHx -----END PGP SIGNATURE----- --wmfuW8osuO2pi9jF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140515135003.GO74331>