Date: Thu, 20 Oct 2022 10:23:43 -0600 From: Alan Somers <asomers@freebsd.org> To: "Kenneth D. Merry" <ken@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 11778fca4a83 - main - Fix mpr(4) panic during a firmware update. Message-ID: <CAOtMX2jLP1icxmw-Q-wry01StSLFt6n7tOVJOJfeUDivS9aEEg@mail.gmail.com> In-Reply-To: <202210171652.29HGqtSf007611@gitrepo.freebsd.org> References: <202210171652.29HGqtSf007611@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 17, 2022 at 10:53 AM Kenneth D. Merry <ken@freebsd.org> wrote: > > The branch main has been updated by ken: > > URL: https://cgit.FreeBSD.org/src/commit/?id=11778fca4a83f5e3b597c75785aa5c0ee0dc518e > > commit 11778fca4a83f5e3b597c75785aa5c0ee0dc518e > Author: Kenneth D. Merry <ken@FreeBSD.org> > AuthorDate: 2022-10-17 16:48:34 +0000 > Commit: Kenneth D. Merry <ken@FreeBSD.org> > CommitDate: 2022-10-17 16:48:34 +0000 > > Fix mpr(4) panic during a firmware update. > > Issue Description: > The RequestCredits field of IOCFacts got changed between the Phase23 > firmware to Phase24 firmware. So as part of firmware update operation, > driver has to free the resources & pools which are created with the Phase23 > Firmware's IOCFacts data (i.e. during driver load time) and has to > reallocate the resources and pools using Phase24's IOCFacts data. Here > driver has freed the interrupts but missed to reallocate the interrupts and > hence config page read operation is getting timed out and controller is > going for recursive reinit (controller reset) operations and leading to > kernel panic. > > Fix: > Reallocate the interrupts if the interrupts are disabled as part of > firmware update/downgrade operation. > > Submitted by: Sreekanth Ready <sreekanth.reddy@broadcom.com> > Tested by: ken > MFC after: 3 days Would this commit fix the panic in bug 252575? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252575
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2jLP1icxmw-Q-wry01StSLFt6n7tOVJOJfeUDivS9aEEg>