Date: Wed, 14 Mar 2001 17:10:32 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Mikhail Teterin <mi@mail.virtual-estates.net> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/www/tclhttpd Makefile Message-ID: <3AAF89E8.1E6674BD@FreeBSD.org> References: <200103141448.JAA29659@mail.virtual-estates.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Mikhail Teterin wrote: > > sobomax 2001/03/14 01:35:21 PST > > > > Modified files: > > www/tclhttpd Makefile > > Log: > > o Fix build by replacing custom do-build target with set of stock > > MAKEFILE/MAKE_ENV/MAKE_ARGS variables. > > o Slightly reorder variables to make Makefile more readable. > > Not that I object to this particular changes, but what happened to: > > http://www.freebsd.org/handbook/policies.html#POLICIES-MAINTAINER > > Specificly: > > Changes to directories which have a maintainer defined shall be > sent to the maintainer for review before being committed. Only > if the maintainer does not respond for an unacceptable period of > time, to several emails, will it be acceptable to commit changes > without review by the maintainer. However, it is suggested that > you try and have the changes reviewed by someone else if at all > possible. > > We exchanged several e-mails yesterday on different topics, with average > latency of less than 30 minutes. You never raised this issue. > > > Submitted by: bento > > I fixed the thing, that was causing bento to fail yesterday: No, you didn't fix it. You ``fixed'' (it was not a real fix - you should not pre-define PREFIX or LOCALBASE) library search path, but did not fixed includes search path (i.e. LOCALBASE was still undefined, so it looked for tcl includes in /include/tclx.y), so I tried to fix it properly. Regards, Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3AAF89E8.1E6674BD>