Date: Mon, 16 Apr 2012 11:02:48 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r234329 - head/lib/libc/net Message-ID: <20120416070248.GQ9391@FreeBSD.org> In-Reply-To: <201204152356.q3FNu4W4007224@svn.freebsd.org> References: <201204152356.q3FNu4W4007224@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 15, 2012 at 11:56:04PM +0000, Eitan Adler wrote: E> Author: eadler E> Date: Sun Apr 15 23:56:03 2012 E> New Revision: 234329 E> URL: http://svn.freebsd.org/changeset/base/234329 E> E> Log: E> When searching for uninitialized memory usage add ensure that the entire E> struct is set to zero. E> E> PR: bin/166483 E> Submitted by: Roy Marples <roy@marples.name> E> Reviewed by: delphij E> Approved by: cperciva E> MFC after: 3 days E> E> Modified: E> head/lib/libc/net/if_nametoindex.c E> E> Modified: head/lib/libc/net/if_nametoindex.c E> ============================================================================== E> --- head/lib/libc/net/if_nametoindex.c Sun Apr 15 23:50:13 2012 (r234328) E> +++ head/lib/libc/net/if_nametoindex.c Sun Apr 15 23:56:03 2012 (r234329) E> @@ -70,6 +70,9 @@ if_nametoindex(const char *ifname) E> E> s = _socket(AF_INET, SOCK_DGRAM, 0); E> if (s != -1) { E> +#ifdef PURIFY E> + memset(&ifr, 0, sizeof(ifr)); E> +#endif E> strlcpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name)); E> if (_ioctl(s, SIOCGIFINDEX, &ifr) != -1) { E> _close(s); Is that PURIFY documented anywhere? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120416070248.GQ9391>