Date: Wed, 01 Aug 2001 13:23:08 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Matt Jacob <mjacob@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/alpha/alpha clock.c Message-ID: <XFMail.010801132308.jhb@FreeBSD.org> In-Reply-To: <200108011940.f71JeBT28007@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01-Aug-01 Matt Jacob wrote: > mjacob 2001/08/01 12:40:11 PDT > > Modified files: > sys/alpha/alpha clock.c > Log: > Don't initialize a clock twice (it's not a function of number of > cpus). Erm, that's not what that is there for. It is there because the clock is not safe for SMP use. I.e., we only use that timecounter in a UP machine. We don't call cpu_initclocks() multiple times. However, on the alpha we always call hardclock() (and thus tc_windup()) on the boot CPU, thus it _might_ be safe for us to use this timecounter on SMP systems. In any case, cpu_initclocks() is only called once, so the 'once' variable is bogus. Please revert that part for now. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010801132308.jhb>