Date: Thu, 24 Mar 2005 08:06:29 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/acpica acpi_perf.c Message-ID: <20050324.080629.36604178.imp@bsdimp.com> In-Reply-To: <4241E29C.7010407@root.org> References: <1111611460.1805.1.camel@localhost> <20050323.143742.74706153.imp@bsdimp.com> <4241E29C.7010407@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <4241E29C.7010407@root.org>
Nate Lawson <nate@root.org> writes:
: Warner Losh wrote:
: >>>Ok, I've committed a fix: acpi.c rev 1.207. Please cvsup and test.
: >>
: >>It does not help, still same panic
: >
: >
: > It doesn't help me either, and an audit of the code suggests that it
: > will have no effect. There's a resource that's marked as being
: > active, which is why the panic is happening.... I've always hated
: > these panics, but have appreciated them in hindsight once the bug has
: > been fixed because it is a very effective enforcement of proper
: > operations.
: >
: > Warner
:
: I'm trying to figure out what's going on. The probe routine should not
: be called multiple times since it returns 0 and now with my commit it
: should completely clean up after itself. Can you put this in
: acpi_perf_identify, probe, attach and let me know the full dmesg up to
: the panic?
I'll give it a try. I'll reiterate that probe routines should do
nothing more than 'I'm here' and all other processing should be done
in attach. It looks like that might be a little hard in this case,
but I've not looked into it in detail.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050324.080629.36604178.imp>