Date: Fri, 10 Jan 2014 09:12:39 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: Using sys/types.h types in sys/socket.h Message-ID: <CAJ-VmoksFZ7ccybM6Ku3y1WAGSWa==VvVFmrO0%2BtwUh17=gvWQ@mail.gmail.com> In-Reply-To: <20140110222640.F2338@besplex.bde.org> References: <CAJ-Vmo=MWPQWfP9duWPPwaKee5Zp9Gemj3GKqE8=bxkjn_1YYA@mail.gmail.com> <9C1291B5-215B-440E-B8B0-6308840F755C@bsdimp.com> <CAJ-Vmom3FQOb1ZQTwbmbSiT90N6tmKOoPg8JPQAapkJg2TXqFA@mail.gmail.com> <5821DA91-E9C7-4D1A-A108-63E74CFF1FC5@bsdimp.com> <20140108152632.L969@besplex.bde.org> <CAJ-VmonemTxS6zvdGU_SvOtnV3bzJ-rKtJcrTEfJ_NY3u7kndA@mail.gmail.com> <20140109092602.M957@besplex.bde.org> <CAJ-VmoncQm2KWjhhAHhArkSGR-wQOxhYeNxzp15R0h5UffQhzA@mail.gmail.com> <20140110222640.F2338@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On 10 January 2014 03:38, Bruce Evans <brde@optusnet.com.au> wrote:
>> /*
>> * sendfile(2) kqueue information
>> */
>> struct sf_hdtr_kq {
>> __uintptr_t kq_ident; /* ident (from userland?) */
>> void *kq_udata; /* user data pointer */
>> __uint32_t kq_flags; /* extra flags to pass in */
>> int kq_fd; /* kq fd to post completion events on */
>> };
>>
>> Ok, so I've removed one tab from the comments and added a tab after
>> void/int.
>>
>> How's that?
>
>
> Now the last comment is misindented.
Ok, I'll fix that.
> This also has the unrelated change of using __ufoo instead of ufoo. I
> think that is only correct if the types are supposed to be almost opaque,
> with the details not part of the API.
Peter raised a point on irc - if I define uint32_t/uintptr_t in the
header, then code that includes sys/socket.h will be able to use
uint32_t / uintptr_t without including sys/types.h.
What should be done there?
-a
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmoksFZ7ccybM6Ku3y1WAGSWa==VvVFmrO0%2BtwUh17=gvWQ>