Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 Jan 2015 16:18:08 -0800
From:      Garrett Cooper <yaneurabeya@gmail.com>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        svn-src-projects@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r277543 - projects/ifnet/sys/net
Message-ID:  <21EFD3A7-91CA-4FF9-BD84-C6AD847A11ED@gmail.com>
In-Reply-To: <201501230002.t0N02R5W099367@svn.freebsd.org>
References:  <201501230002.t0N02R5W099367@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_BF38F50E-EF39-4C35-A731-1A4E35746C86
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=windows-1252

On Jan 22, 2015, at 16:02, Gleb Smirnoff <glebius@FreeBSD.org> wrote:

> Author: glebius
> Date: Fri Jan 23 00:02:26 2015
> New Revision: 277543
> URL: https://svnweb.freebsd.org/changeset/base/277543
>=20
> Log:
>  Return EOPNOTSUPP in case of not supported option.
>=20
> Modified:
>  projects/ifnet/sys/net/if_ethersubr.c
>=20
> Modified: projects/ifnet/sys/net/if_ethersubr.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- projects/ifnet/sys/net/if_ethersubr.c	Thu Jan 22 23:59:35 2015	=
(r277542)
> +++ projects/ifnet/sys/net/if_ethersubr.c	Fri Jan 23 00:02:26 2015	=
(r277543)
> @@ -985,7 +985,7 @@ ether_ioctl(struct ifnet *ifp, u_long co
> 		}
> 		break;
> 	default:
> -		error =3D EINVAL;			/* XXX netbsd =
has ENOTTY??? */
> +		error =3D EOPNOTSUPP;
> 		break;
> 	}
> 	return (error);

Uh, didn=92t you just break the ioctl(2) ERRORS guarantee?

     [EBADF]            The fd argument is not a valid descriptor.

     [ENOTTY]           The fd argument is not associated with a =
character
                        special device.

     [ENOTTY]           The specified request does not apply to the kind =
of
                        object that the descriptor fd references.

     [EINVAL]           The request or argp argument is not valid.

     [EFAULT]           The argp argument points outside the process's
                        allocated address space.

--Apple-Mail=_BF38F50E-EF39-4C35-A731-1A4E35746C86
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJUwZNAAAoJEMZr5QU6S73eWZ0H/0Zr7K9rAT5uqt2+rE062TPs
98cFQ3hmycz5R+83h/gE+zoyq6nVhtCAh+QVpn9tpHRhl8USpg7DErhFxuekbT6E
vkNEsSRdgf17EIyMPBFHhotV3NfmYhVeuuc0hTlsWMyVoxgQp6XA6V8aR/W2dLoN
yqZrnxf6olWvr5zYtyQkpt81lxNA/9JawcfqvPntbR7LncsSw1j8VnLM1nuDW+ou
0xTE95gtZ3Tb3YrXc37I3HIFbAbM0o6fNU2s3Vs5xikRhcSM/2P5WSB0BykByfIv
3q4hbK81MFjKIXEJ+gZ8DXqrQkG9ShvSKqkChhD1yiHMfhzLur1sZvJ3Wzw64kU=
=dC2W
-----END PGP SIGNATURE-----

--Apple-Mail=_BF38F50E-EF39-4C35-A731-1A4E35746C86--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?21EFD3A7-91CA-4FF9-BD84-C6AD847A11ED>