Date: Sun, 13 Nov 2011 00:01:41 +0400 From: "Andrey V. Elsukov" <ae@FreeBSD.org> To: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org> Cc: freebsd-current@FreeBSD.org Subject: Re: [Call for reviews] Support domain-search option in dhclient(8) Message-ID: <4EBED0A5.5070308@FreeBSD.org> In-Reply-To: <4EBE99A7.90500@FreeBSD.org> References: <4EBE99A7.90500@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 12.11.2011 20:07, Jean-Sébastien Pédron wrote: > Attached is a patch that adds support for "domain-search" option > (#119) as defined in RFC 3397[1]. This allows a DHCP server to publish > a list of domain names that should be used to search for non-fully > qualified domain names. > > There's already a PR opened about this: > http://www.freebsd.org/cgi/query-pr.cgi?pr=151940 > > With this patch applied and a DHCP server configured to publish this > option, dhclient(8) will add a line similar to the following one: > search example.org. foobar.com. > > In the example, this indicates that the name "www" should be resolved > first as "www.example.org", then as "www.foobar.com". > > I prepared a regression test to be added to tools/regression (not > included). However, I'm not knowledgeable enough to anticipate all > security-related issues. I would appreciate a review especially with > this in mind :) Hi, I have several questions after a quick view of your patch: 1. AFAIR, our dhclient was doing changes in the system configuration via dhclient-script, but i don't see that your changes touched it. 2. Your code handles compressed options. It's good. But it seems you don't check names correctness. There were some checks for "domain-name" option, probably you can use them. 3. Also it would be good to update man pages :) -- WBR, Andrey V. Elsukov [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJOvtCqAAoJEAHF6gQQyKF6cvYH/3yQjZQO9UdMmBchPal3t80c qhco1LTTtNIcwA019PzoJh614S5ytLRsWVGjLOJJbDS35w+AoPPmTX4iFlulF8bi Iy4VPGiowaOAavazppGMAzR7TSFY4xqjk2H8Feh5UBJe6MXyksggrscF0yaOvIlt wggqXM3TsEZhL6GNHIZobdVPNdYDg+GGDeO2707fANEPsO8mVz8FAY5IEKEs3jXU w+lLjmI6t5kX6byhY1XGF+BKudBzs4TGiQzWPBSseV1LAoy0VFIoJmMB4pN8Cnjh jflUxBi/dvM7hfwMyZxZff35xuD2CeM7tO6dxkUx5eOx0kLXUNYe2kqHMILd2S4= =mRTL -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EBED0A5.5070308>