Date: Wed, 15 Feb 2012 08:46:57 +0000 (UTC) From: Doug Barton <dougb@FreeBSD.org> To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: ports/sysutils/smartmontools Makefile pkg-plist ports/sysutils/smartmontools/files smartd.in Message-ID: <201202150846.q1F8kvCi051291@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
dougb 2012-02-15 08:46:57 UTC
FreeBSD ports repository
Modified files:
sysutils/smartmontools Makefile pkg-plist
sysutils/smartmontools/files smartd.in
Log:
This change has various simplifications/improvements for
the port. Most importantly, it's currently installing the rc.d
script from the source, rather than the fixed one in files/.
1. Remove 6.x compatibility hack
2. Use the PORTDOCS macro
3. Actually install the rc.d script in files/
4. Simplify pkg-plist
5. For the rc.d script:
a. Move it to the standard location, after LOGIN
b. Add KEYWORD nojail per the script in the distfiles
c. Put the standard arguments in their usual order/formats
d. Simplify the assignments of pidfile and required_files
e. Use command_args for required arguments, don't abuse _flags
f. The test for -p in smartd_flags should be a start_precmd,
we frown on running any code unconditionally.
Also, improve this check if -p is first.
g. Bring the reload and report options from the distfile version,
and simplify them.
PR: ports/165167
Submitted by: me
Approved by: Alex Samorukov <samm@os2.kiev.ua> (maintainer)
Revision Changes Path
1.57 +4 -4 ports/sysutils/smartmontools/Makefile
1.4 +51 -25 ports/sysutils/smartmontools/files/smartd.in
1.8 +1 -19 ports/sysutils/smartmontools/pkg-plist
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201202150846.q1F8kvCi051291>