Date: Sun, 19 Feb 2023 03:16:39 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 0b69409270e4 - releng/13.2 - powerpc: Drop old workaround for old gcc Message-ID: <202302190316.31J3GdQA084001@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch releng/13.2 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=0b69409270e47fc90fa7141098c2621e4df1c45c commit 0b69409270e47fc90fa7141098c2621e4df1c45c Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2023-02-16 16:58:33 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2023-02-19 03:14:24 +0000 powerpc: Drop old workaround for old gcc Very old versions of gcc defined _BIG_ENDIAN and _LITTLE_ENDIAN. So to work around that, we undefined them here. However, that causes problems for programs that do: (and many other variations on that theme). Since this often is the result of weirdly nested includes in the ports world that are hard to unwind, drop this workaround to help more ports build out of the box. If there's still an issue here (and my testing hasn't shown it), we'll fix the issue in a brand-new way once I have a reproducer. This fixes the mesa-devel build, and others Sponsored by: Netflix Tested by: pkubaj MFC After: 3 days Differential Revision: https://reviews.freebsd.org/D38564 Approved by: re (cperciva) (cherry picked from commit e35448a901aa56aa232efbc4fe7a73a9bdac3511) (cherry picked from commit a86b9ed22ece362331f44a933bbf5426a06f527a) --- sys/powerpc/include/endian.h | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/sys/powerpc/include/endian.h b/sys/powerpc/include/endian.h index 9e28237bfd24..0fac50361632 100644 --- a/sys/powerpc/include/endian.h +++ b/sys/powerpc/include/endian.h @@ -36,18 +36,6 @@ #define _MACHINE_ENDIAN_H_ #include <sys/_types.h> - -/* - * GCC defines _BIG_ENDIAN and _LITTLE_ENDIAN equal to __BIG_ENDIAN__ - * and __LITTLE_ENDIAN__ (resp). - */ -#ifdef _BIG_ENDIAN -#undef _BIG_ENDIAN -#endif -#ifdef _LITTLE_ENDIAN -#undef _LITTLE_ENDIAN -#endif - #include <sys/_endian.h> #endif /* !_MACHINE_ENDIAN_H_ */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202302190316.31J3GdQA084001>