Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 12 Feb 2018 17:44:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 225450] 11.1-* panics on AMD Opteron 2k due to EARLY_AP_STARTUP
Message-ID:  <bug-225450-8-H73Di1UxpE@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-225450-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-225450-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225450

--- Comment #16 from John Baldwin <jhb@FreeBSD.org> ---
(In reply to Pablo Ruiz from comment #14)
Thanks, this gives me what I was looking for.  We have infinite recursion
because the spin lock code is calling DELAY() which is trying to grab a spin
lock.

One question is why isn't DELAY using the tsc?

Hmm, it seems 'tsc_is_invariant' isn't set.  Are these older AMD CPUs?

You can try this as a hack-workaround to verify it fixes the issue, but I n=
eed
to think a bit more about what the right fix might be:

Index: x86/x86/delay.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- delay.c     (revision 329004)
+++ delay.c     (working copy)
@@ -72,7 +72,7 @@
                func =3D get_tsc;
                mask =3D ~0u;
        } else {
-               if (tc->tc_quality <=3D 0)
+               if (tc->tc_quality <=3D 0 || n =3D=3D 1)
                        return (0);
                func =3D tc->tc_get_timecount;
                mask =3D tc->tc_counter_mask;

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-225450-8-H73Di1UxpE>