Date: Fri, 9 Feb 2018 13:22:08 -0700 From: Warner Losh <imp@bsdimp.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: svn commit: r329064 - head/share/zoneinfo Message-ID: <CANCZdfr8P_-D6BprNqJOJYsEq6u9FC9EP2h4_GB120CmrbVRYA@mail.gmail.com> In-Reply-To: <20180209190450.GA85711@FreeBSD.org> References: <201802091550.w19FoXEb018181@repo.freebsd.org> <14002093.zLdzgIqnsv@ralph.baldwin.cx> <CANCZdfrz4ph4YQnS6AvfKhtMMpAT74-7cnZcONfs2w-9r9tG_Q@mail.gmail.com> <20180209190450.GA85711@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 9, 2018 at 12:04 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, Feb 09, 2018 at 11:50:35AM -0700, Warner Losh wrote: > > On Fri, Feb 9, 2018 at 10:49 AM, John Baldwin <jhb@freebsd.org> wrote: > > > On Friday, February 09, 2018 03:50:33 PM Warner Losh wrote: > > > > New Revision: 329064 > > > > URL: https://svnweb.freebsd.org/changeset/base/329064 > > > > > > > > Log: > > > > We don't actually need env here, so drop it. All shells allow > setting > > > > of shell variables for the next command like this. > > > > > > Eh: > > > > > > % LC_ALL=C env > > > LC_ALL=C: Command not found. > > > > > > csh and tcsh don't let you set environment variables as a prefix. > > > > > > That said, if you try to use csh as the SHELL for make I bet many > things > > > would break. > > > > Right, all shells supported as SHELL for make. csh isn't on the list of > > supported shells. Your bet is right: a lot of things do break. > > I don't really understand why we're discussing it: (t)csh, fish, whatever > are for interactive use *only*. Scripts (and makefiles) should only be > written for standard plain POSIX shell. > Right. 'all shells' in my original simply meant that this has been a feature of /bin/sh for long enough that we won't have anything to worry about if we build on a foreign OS using something weird like bash. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr8P_-D6BprNqJOJYsEq6u9FC9EP2h4_GB120CmrbVRYA>