Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Oct 2022 18:09:56 GMT
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: eda633455a63 - main - tcp: remove useless today lock assertion in a middle of function
Message-ID:  <202210251809.29PI9uYD065321@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=eda633455a63421976d7d9fd093dc6b665de2c64

commit eda633455a63421976d7d9fd093dc6b665de2c64
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2022-10-25 18:09:22 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2022-10-25 18:09:22 +0000

    tcp: remove useless today lock assertion in a middle of function
    
    It was added back in 7cfc6904408b, when there was a jump label
    above and tcp_input() hadn't been locked all through.
---
 sys/netinet/tcp_input.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c
index 672776e4e882..1ea3d72d9a9d 100644
--- a/sys/netinet/tcp_input.c
+++ b/sys/netinet/tcp_input.c
@@ -2131,8 +2131,6 @@ tcp_do_segment(struct mbuf *m, struct tcphdr *th, struct socket *so,
 			tcp_state_change(tp, TCPS_SYN_RECEIVED);
 		}
 
-		INP_WLOCK_ASSERT(tp->t_inpcb);
-
 		/*
 		 * Advance th->th_seq to correspond to first data byte.
 		 * If data, trim to stay within window,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202210251809.29PI9uYD065321>