Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 25 Apr 2018 17:59:59 -0600
From:      Ian Lepore <ian@freebsd.org>
To:        Li-Wen Hsu <lwhsu@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r333010 - head/sys/mips/mips
Message-ID:  <1524700799.57768.111.camel@freebsd.org>
In-Reply-To: <201804251946.w3PJkdkH040243@repo.freebsd.org>
References:  <201804251946.w3PJkdkH040243@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2018-04-25 at 19:46 +0000, Li-Wen Hsu wrote:
> Author: lwhsu (ports committer)
> Date: Wed Apr 25 19:46:39 2018
> New Revision: 333010
> URL: https://svnweb.freebsd.org/changeset/base/333010
> 
> Log:
>   Fix mips32 build after r332951.
>   
>   Approved by:	jhb
> 
> Modified:
>   head/sys/mips/mips/pm_machdep.c
> 
> Modified: head/sys/mips/mips/pm_machdep.c
> ==============================================================================
> --- head/sys/mips/mips/pm_machdep.c	Wed Apr 25 18:59:29 2018	(r333009)
> +++ head/sys/mips/mips/pm_machdep.c	Wed Apr 25 19:46:39 2018	(r333010)
> @@ -264,7 +264,7 @@ ptrace_single_step(struct thread *td)
>  		va = locr0->pc + 4;
>  	}
>  	if (td->td_md.md_ss_addr) {
> -		printf("SS %s (%d): breakpoint already set at %lx (va %lx)\n",
> +		printf("SS %s (%d): breakpoint already set at %zx (va %zx)\n",
>  		    p->p_comm, p->p_pid, td->td_md.md_ss_addr, va); /* XXX */
>  		error = EFAULT;
>  		goto out;
> @@ -500,7 +500,7 @@ ptrace_clear_single_step(struct thread *td)
>  
>  	if (error != 0) {
>  		log(LOG_ERR,
> -		    "SS %s %d: can't restore instruction at %lx: %x\n",
> +		    "SS %s %d: can't restore instruction at %zx: %x\n",
>  		    p->p_comm, p->p_pid, td->td_md.md_ss_addr,
>  		    td->td_md.md_ss_instr);
>  	}
> 

This isn't right either.  %z is for size_t values, both md_ss_addr and
va are integers and a plain %x should be the right format.

-- Ian



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1524700799.57768.111.camel>