Date: Wed, 18 Dec 2013 13:51:01 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r259555 - in head/contrib: gcc gcc/doc gcclibs/libcpp gcclibs/libcpp/include Message-ID: <52B1EE95.3030104@FreeBSD.org> In-Reply-To: <20131218154253.GA18580@FreeBSD.org> References: <201312181453.rBIEranx037463@svn.freebsd.org> <20131218154253.GA18580@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18.12.2013 10:42, Alexey Dokuchaev wrote: > On Wed, Dec 18, 2013 at 02:53:36PM +0000, Pedro F. Giffuni wrote: >> New Revision: 259555 >> URL: http://svnweb.freebsd.org/changeset/base/259555 >> >> Log: >> gcc: add Apple compatible -Wnewline-eof >> >> GCC 4.2 and previous have always warned about >> "No newline at end of file". >> >> Upstream GCC removed the warning completely but >> Apple made it an optional warning. Adopt it for >> compatibility with older GCC and clang. > As someone who hates files that lack newline at EOF, I could never understand > why they (upstream) removed this warning. > > ./danfe The main discussion took place here: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14331 FWIW, I like the warning too. Cheers, Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52B1EE95.3030104>