Date: Thu, 25 Apr 2002 20:52:55 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: Jordan Hubbard <jkh@winston.freebsd.org> Cc: Dag-Erling Smorgrav <des@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, core@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh servconf.c sshd_config Message-ID: <Pine.NEB.3.96L.1020425204951.55944W-100000@fledge.watson.org> In-Reply-To: <3956.1019770217@winston.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 25 Apr 2002, Jordan Hubbard wrote: > I would have backed it out myself today if you'd have at least given me > a chance to address this. In fact, I tried to do so but you'd already > jumped in ahead of me and I noticed only when my diffs failed to apply. > > I really don't care for your style, DES, and no amount of > self-justification gives any of us the right to simply back stuff out > before discussion has even ended. You're not god and nobody appointed > you to the position, so stop acting like they did. > > I'm even more than willing to admit that I erred in applying this to > -current, and I came to that understanding less than 24 hours after > making the change and sought to rectify it, but you wouldn't even give > me the chance to shoot my own dog. > > This is two strikes against you and I'm officially going on record in > saying that one more offense and you're history. We don't need battling > commits in the repo and we don't need developers who feel justified in > tromping on other people's toes anytime they feel compelled to do so. > This is a matter of principle now. Let's not blow this out of proportion. Your proposed patch was objected to on valid technical grounds, and your proposed patch was broken in several ways. In fact, it didn't even fix a problem in -CURRENT, because the problem didn't even exist there, which I pointed out to you explicitly in my request that you not commit the patch. DES backed out your commit (in -CURRENT, where it was broken, and in -STABLE, where it broke existing configurations), and replaced it with a working fix immediately. Sure, he committed fast, but you committed pretty quickly too. Rather than turn this into yet another battle to the death, just accept that he fixed the bug (properly) and is willing to do work to maintain OpenSSH. He stepped up to do the merge work on a new version of OpenSSH, which is something that no one else was willing to do, so we can give him some breathing room. There was no rush to fix the bug either: it's not as though we have a release tomorrow. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1020425204951.55944W-100000>