Date: Fri, 19 Jun 2020 07:07:15 -0400 From: Mark Johnston <markj@freebsd.org> To: Li-Wen Hsu <lwhsu@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r362361 - in head/sys: compat/linuxkpi/common/src vm Message-ID: <20200619110715.GD97300@raichu> In-Reply-To: <CAKBkRUxS8402Z_bO5mOe9%2BfphHAahAh40WpV5O5=yyeFuW_q1w@mail.gmail.com> References: <202006190332.05J3W53u006443@repo.freebsd.org> <CAKBkRUxS8402Z_bO5mOe9%2BfphHAahAh40WpV5O5=yyeFuW_q1w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 19, 2020 at 06:02:18PM +0800, Li-Wen Hsu wrote: > On Fri, Jun 19, 2020 at 11:32 AM Mark Johnston <markj@freebsd.org> wrote: > > > > Author: markj > > Date: Fri Jun 19 03:32:04 2020 > > New Revision: 362361 > > URL: https://svnweb.freebsd.org/changeset/base/362361 > > > > Log: > > Add a helper function for validating VA ranges. > > > > Functions which take untrusted user ranges must validate against the > > bounds of the map, and also check for wraparound. Instead of having the > > same logic duplicated in a number of places, add a function to check. > > > > Reviewed by: dougm, kib > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D25328 > > I'm not sure if it's this one, or 3623630, the following i386 tests > all panicked: It was 3623630, which was totally wrong. > https://ci.freebsd.org/job/FreeBSD-head-i386-test/9681/console > > 00:11:31.669 lib/libc/net/protoent_test:protoent -> panic: > __rw_wlock_hard: recursing but non-recursive rw vm object @ > /usr/src/sys/vm/vm_object.c:869 > > https://ci.freebsd.org/job/FreeBSD-head-i386-test/9682/console > (includes the fix or r362363) > > 00:27:53.864 bin/pkill/pkill-j_test:main -> Sleeping thread (tid > 100115, pid 65628) owns a non-sleepable lock > > https://ci.freebsd.org/job/FreeBSD-head-i386-test/9683/console > > 00:02:26.917 bin/pkill/pkill-j_test:main -> Sleeping thread (tid > 100152, pid 26582) owns a non-sleepable lock > > Can you help check these? I reverted the change. Sorry for the breakage.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200619110715.GD97300>