Date: Thu, 14 Apr 2016 05:10:42 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r297955 - in head/sys: geom geom/mirror geom/raid3 sys Message-ID: <201604140510.u3E5AgwH041236@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: imp Date: Thu Apr 14 05:10:41 2016 New Revision: 297955 URL: https://svnweb.freebsd.org/changeset/base/297955 Log: Bump bio_cmd and bio_*flags from 8 bits to 16. Differential Revision: https://reviews.freebsd.org/D5784 Modified: head/sys/geom/geom_io.c head/sys/geom/geom_subr.c head/sys/geom/mirror/g_mirror.c head/sys/geom/raid3/g_raid3.c head/sys/sys/bio.h head/sys/sys/buf.h Modified: head/sys/geom/geom_io.c ============================================================================== --- head/sys/geom/geom_io.c Thu Apr 14 04:59:51 2016 (r297954) +++ head/sys/geom/geom_io.c Thu Apr 14 05:10:41 2016 (r297955) @@ -504,11 +504,11 @@ g_io_request(struct bio *bp, struct g_co cmd = bp->bio_cmd; if (cmd == BIO_READ || cmd == BIO_WRITE || cmd == BIO_GETATTR) { KASSERT(bp->bio_data != NULL, - ("NULL bp->data in g_io_request(cmd=%hhu)", bp->bio_cmd)); + ("NULL bp->data in g_io_request(cmd=%hu)", bp->bio_cmd)); } if (cmd == BIO_DELETE || cmd == BIO_FLUSH) { KASSERT(bp->bio_data == NULL, - ("non-NULL bp->data in g_io_request(cmd=%hhu)", + ("non-NULL bp->data in g_io_request(cmd=%hu)", bp->bio_cmd)); } if (cmd == BIO_READ || cmd == BIO_WRITE || cmd == BIO_DELETE) { Modified: head/sys/geom/geom_subr.c ============================================================================== --- head/sys/geom/geom_subr.c Thu Apr 14 04:59:51 2016 (r297954) +++ head/sys/geom/geom_subr.c Thu Apr 14 05:10:41 2016 (r297955) @@ -1508,8 +1508,8 @@ DB_SHOW_COMMAND(bio, db_show_bio) db_printf("BIO %p\n", bp); db_print_bio_cmd(bp); db_print_bio_flags(bp); - db_printf(" cflags: 0x%hhx\n", bp->bio_cflags); - db_printf(" pflags: 0x%hhx\n", bp->bio_pflags); + db_printf(" cflags: 0x%hx\n", bp->bio_cflags); + db_printf(" pflags: 0x%hx\n", bp->bio_pflags); db_printf(" offset: %jd\n", (intmax_t)bp->bio_offset); db_printf(" length: %jd\n", (intmax_t)bp->bio_length); db_printf(" bcount: %ld\n", bp->bio_bcount); Modified: head/sys/geom/mirror/g_mirror.c ============================================================================== --- head/sys/geom/mirror/g_mirror.c Thu Apr 14 04:59:51 2016 (r297954) +++ head/sys/geom/mirror/g_mirror.c Thu Apr 14 05:10:41 2016 (r297955) @@ -1905,7 +1905,7 @@ g_mirror_worker(void *arg) g_mirror_sync_request(bp); /* WRITE */ else { KASSERT(0, - ("Invalid request cflags=0x%hhx to=%s.", + ("Invalid request cflags=0x%hx to=%s.", bp->bio_cflags, bp->bio_to->name)); } } else { Modified: head/sys/geom/raid3/g_raid3.c ============================================================================== --- head/sys/geom/raid3/g_raid3.c Thu Apr 14 04:59:51 2016 (r297954) +++ head/sys/geom/raid3/g_raid3.c Thu Apr 14 05:10:41 2016 (r297955) @@ -2127,7 +2127,7 @@ process: g_raid3_sync_request(bp); /* WRITE */ else { KASSERT(0, - ("Invalid request cflags=0x%hhx to=%s.", + ("Invalid request cflags=0x%hx to=%s.", bp->bio_cflags, bp->bio_to->name)); } } else if (g_raid3_register_request(bp) != 0) { Modified: head/sys/sys/bio.h ============================================================================== --- head/sys/sys/bio.h Thu Apr 14 04:59:51 2016 (r297954) +++ head/sys/sys/bio.h Thu Apr 14 05:10:41 2016 (r297955) @@ -77,10 +77,10 @@ typedef void bio_task_t(void *); * The bio structure describes an I/O operation in the kernel. */ struct bio { - uint8_t bio_cmd; /* I/O operation. */ - uint8_t bio_flags; /* General flags. */ - uint8_t bio_cflags; /* Private use by the consumer. */ - uint8_t bio_pflags; /* Private use by the provider. */ + uint16_t bio_cmd; /* I/O operation. */ + uint16_t bio_flags; /* General flags. */ + uint16_t bio_cflags; /* Private use by the consumer. */ + uint16_t bio_pflags; /* Private use by the provider. */ struct cdev *bio_dev; /* Device to do I/O on. */ struct disk *bio_disk; /* Valid below geom_disk.c only */ off_t bio_offset; /* Offset into file. */ Modified: head/sys/sys/buf.h ============================================================================== --- head/sys/sys/buf.h Thu Apr 14 04:59:51 2016 (r297954) +++ head/sys/sys/buf.h Thu Apr 14 05:10:41 2016 (r297955) @@ -98,8 +98,8 @@ struct buf { void *b_caller1; caddr_t b_data; int b_error; - uint8_t b_iocmd; /* BIO_* bio_cmd from bio.h */ - uint8_t b_ioflags; /* BIO_* bio_flags from bio.h */ + uint16_t b_iocmd; /* BIO_* bio_cmd from bio.h */ + uint16_t b_ioflags; /* BIO_* bio_flags from bio.h */ off_t b_iooffset; long b_resid; void (*b_iodone)(struct buf *);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604140510.u3E5AgwH041236>