Date: Tue, 15 Nov 2005 20:23:06 +0800 From: Ariff Abdullah <ariff@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: src-committers@FreeBSD.org, kan@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, arr@FreeBSD.org, Alexander@Leidinger.net Subject: Re: cvs commit: src/sys/dev/sound/pcm channel.c Message-ID: <20051115202306.4cf2dcf2.ariff@FreeBSD.org> In-Reply-To: <20051115095801.M61850@fledge.watson.org> References: <200511150419.jAF4JRUp080869@repoman.freebsd.org> <20051115105128.a5dd001i0ckock0s@netchild.homeip.net> <20051115095801.M61850@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, 15 Nov 2005 09:58:52 +0000 (GMT) Robert Watson <rwatson@FreeBSD.org> wrote: > > On Tue, 15 Nov 2005, Alexander Leidinger wrote: > > >> Modified files: > >> sys/dev/sound/pcm channel.c > >> Log: > >> Unbreak kernel builds. > >> > >> Submitted by: arr > > > > Hos does the change from "min & (min-1) == 0" to "(min & (min-1)) > > == 0" fix the building of a kernel (what was the error message > > from gcc)? > > Probably a combination of -Wall and -Werror, which generally > generates a warning along the following lines: > > warning: suggest parentheses around comparison in operand of & > That means, warnings caused by excessive inlining while compiling maestro.c should also break the build if WARNS=1, right? Has anybody encounter and getting annoyed by this? -- Ariff Abdullah FreeBSD [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDedMtlr+deMUwTNoRAr9sAKDDWwh/yvMxOXCDJm600L8YdoQCVACdGowq xPpZCMWtf7uBXc85/HQLsUY= =KMCB -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051115202306.4cf2dcf2.ariff>