Date: Tue, 22 Aug 2023 18:31:19 -0600 From: Warner Losh <imp@bsdimp.com> To: Kevin Bowling <kevin.bowling@kev009.com> Cc: Kristof Provost <kp@freebsd.org>, Sumit Saxena <sumit.saxena@broadcom.com>, Warner Losh <imp@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor Message-ID: <CANCZdfr6fkKPLVA2JAHiSJSsJj9-tQbFGuK%2BPj2JsEZ24qRENw@mail.gmail.com> In-Reply-To: <CANCZdfrO7gJDsnUu465CN96V4eWowtD-eqH2340u1-Yo14F4_w@mail.gmail.com> References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> <CAK7dMtCJhwpV96znB4if48FtWEy091ss-nmvMp5zoLUvtkAs%2BA@mail.gmail.com> <CAK7dMtA6FL%2BCzw9Z2TC2-N0cA=WshDBsEVam0__ift9VfFrq7Q@mail.gmail.com> <CANCZdfrO7gJDsnUu465CN96V4eWowtD-eqH2340u1-Yo14F4_w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Aug 22, 2023, 6:26 PM Warner Losh <imp@bsdimp.com> wrote: > > > On Tue, Aug 22, 2023, 5:59 PM Kevin Bowling <kevin.bowling@kev009.com> > wrote: > >> On Tue, Aug 22, 2023 at 3:39 PM Kevin Bowling <kevin.bowling@kev009.com> >> wrote: >> > >> > >> > >> > On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost <kp@freebsd.org> wrote: >> >> >> >> On 27 Jun 2023, at 11:17, Kristof Provost wrote: >> >> >> >> On 4 Nov 2022, at 23:55, Warner Losh wrote: >> >> >> >> The branch main has been updated by imp: >> >> >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=91fcacc355971f74aa26fc7861020dc3a2a2d717 >> >> >> >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 >> >> Author: Sumit Saxena <sumit.saxena@broadcom.com> >> >> AuthorDate: 2022-11-04 22:24:32 +0000 >> >> Commit: Warner Losh <imp@FreeBSD.org> >> >> CommitDate: 2022-11-04 22:24:32 +0000 >> >> >> >> if_bnxt: Add support for VLAN on Thor >> >> >> >> Reviewed by: imp >> >> Differential Revision: https://reviews.freebsd.org/D36443 >> >> --- >> >> sys/dev/bnxt/bnxt.h | 3 +- >> >> sys/dev/bnxt/bnxt_hwrm.c | 110 >> ++++++++++++++++++++++++++++------------------- >> >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- >> >> sys/dev/bnxt/if_bnxt.c | 7 ++- >> >> 4 files changed, 74 insertions(+), 53 deletions(-) >> >> >> >> This commit appears to have broken vlan on these interfaces. >> >> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in >> a Dell T640, if that helps). >> >> >> >> A simple vlan creation on top of one: >> >> ifconfig vlan create >> >> ifconfig vlan0 vlan 201 vlandev bnxt0 >> >> >> >> Results in a loss of connectivity. The kernel logs this, which I >> assume is related: >> >> >> >> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS >> error.` >> >> >> >> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I >> can create vlan interfaces on top of bnxt0 without losing connectivity. >> >> >> >> >> >> Should we revert this before 14.0? >> >> >> >> There’s also a report of what I think is the same issue in >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269133 >> >> >> >> There’s a proposed patch there, but it did not work for me. >> > >> > >> > In markj’s analysis he mentions the issue of the reinit. >> > >> > It sounds like there are multiple bugs in this driver but one quick >> band aid may be to mark the driver as not needing re-init for VLAN >> modifications.. that sounds unlikely and was probably an accident when the >> if reset functionality was added. You can check e1000 for that. >> >> Here's what I mean as a patch https://reviews.freebsd.org/D41558 >> >> > Note I don’t have this hw and haven’t audited the code so this could be >> noise but it’s an easy thing to check. >> > > Is there a good bug we can post that link to for someone to test? > Duh.. posted to bug above and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222680 Warner > Warner > >> > >> >> Best regards, >> >> Kristof >> > [-- Attachment #2 --] <div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 22, 2023, 6:26 PM Warner Losh <<a href="mailto:imp@bsdimp.com">imp@bsdimp.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 22, 2023, 5:59 PM Kevin Bowling <<a href="mailto:kevin.bowling@kev009.com" target="_blank" rel="noreferrer">kevin.bowling@kev009.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Aug 22, 2023 at 3:39 PM Kevin Bowling <<a href="mailto:kevin.bowling@kev009.com" rel="noreferrer noreferrer" target="_blank">kevin.bowling@kev009.com</a>> wrote:<br> ><br> ><br> ><br> > On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost <<a href="mailto:kp@freebsd.org" rel="noreferrer noreferrer" target="_blank">kp@freebsd.org</a>> wrote:<br> >><br> >> On 27 Jun 2023, at 11:17, Kristof Provost wrote:<br> >><br> >> On 4 Nov 2022, at 23:55, Warner Losh wrote:<br> >><br> >> The branch main has been updated by imp:<br> >><br> >> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=91fcacc355971f74aa26fc7861020dc3a2a2d717" rel="noreferrer noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=91fcacc355971f74aa26fc7861020dc3a2a2d717</a><br>; >><br> >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717<br> >> Author: Sumit Saxena <<a href="mailto:sumit.saxena@broadcom.com" rel="noreferrer noreferrer" target="_blank">sumit.saxena@broadcom.com</a>><br> >> AuthorDate: 2022-11-04 22:24:32 +0000<br> >> Commit: Warner Losh <imp@FreeBSD.org><br> >> CommitDate: 2022-11-04 22:24:32 +0000<br> >><br> >> if_bnxt: Add support for VLAN on Thor<br> >><br> >> Reviewed by: imp<br> >> Differential Revision: <a href="https://reviews.freebsd.org/D36443" rel="noreferrer noreferrer noreferrer" target="_blank">https://reviews.freebsd.org/D36443</a><br>; >> ---<br> >> sys/dev/bnxt/bnxt.h | 3 +-<br> >> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++-------------------<br> >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++-<br> >> sys/dev/bnxt/if_bnxt.c | 7 ++-<br> >> 4 files changed, 74 insertions(+), 53 deletions(-)<br> >><br> >> This commit appears to have broken vlan on these interfaces.<br> >> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a Dell T640, if that helps).<br> >><br> >> A simple vlan creation on top of one:<br> >> ifconfig vlan create<br> >> ifconfig vlan0 vlan 201 vlandev bnxt0<br> >><br> >> Results in a loss of connectivity. The kernel logs this, which I assume is related:<br> >><br> >> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error.`<br> >><br> >> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I can create vlan interfaces on top of bnxt0 without losing connectivity.<br> >><br> >><br> >> Should we revert this before 14.0?<br> >><br> >> There’s also a report of what I think is the same issue in <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269133" rel="noreferrer noreferrer noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269133</a><br>; >><br> >> There’s a proposed patch there, but it did not work for me.<br> ><br> ><br> > In markj’s analysis he mentions the issue of the reinit.<br> ><br> > It sounds like there are multiple bugs in this driver but one quick band aid may be to mark the driver as not needing re-init for VLAN modifications.. that sounds unlikely and was probably an accident when the if reset functionality was added. You can check e1000 for that.<br> <br> Here's what I mean as a patch <a href="https://reviews.freebsd.org/D41558" rel="noreferrer noreferrer noreferrer" target="_blank">https://reviews.freebsd.org/D41558</a><br>; <br> > Note I don’t have this hw and haven’t audited the code so this could be noise but it’s an easy thing to check.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Is there a good bug we can post that link to for someone to test?</div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Duh.. posted to bug above and</div><div dir="auto"><a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222680">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222680</a></div><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div dir="auto"><br></div><div dir="auto">Warner</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> ><br> >> Best regards,<br> >> Kristof<br> </blockquote></div></div></div> </blockquote></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr6fkKPLVA2JAHiSJSsJj9-tQbFGuK%2BPj2JsEZ24qRENw>