Date: Wed, 15 Mar 2017 13:51:33 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Dimitry Andric <dim@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Meny Yossefi <menyy@mellanox.com> Subject: Re: svn commit: r310232 - head/sys/dev/mlx4/mlx4_ib Message-ID: <9290641f-00e0-4091-e641-448d2d0d24d6@selasky.org> In-Reply-To: <201612181521.uBIFLcB3030383@repo.freebsd.org> References: <201612181521.uBIFLcB3030383@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Can you MFC this patch to 11-stable and 10-stable. The directory layout is a bit different, so you'll need to manually apply the patch to sys/ofed/drivers/infiniband/hw/mlx4/sysfs.c after merging the patch and resolving the non-existing path. --HPS On 12/18/16 16:21, Dimitry Andric wrote: > Author: dim > Date: Sun Dec 18 15:21:38 2016 > New Revision: 310232 > URL: https://svnweb.freebsd.org/changeset/base/310232 > > Log: > After r310171, the kernel version of sscanf() has format string checking > enabled. This results in a -Werror warning in mlx4ib: > > sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c:90:22: error: format specifies type 'unsigned long long *' but the argument has type 'u64 *' (aka 'unsigned long *') [-Werror,-Wformat] > sscanf(buf, "%llx", &sysadmin_ag_val); > ~~~~ ^~~~~~~~~~~~~~~~ > > Change sysadmin_ag_val to unsigned long long to avoid the warning. > > Reviewed by: hselasky > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D8831 > > Modified: > head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c > > Modified: head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c > ============================================================================== > --- head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c Sun Dec 18 15:10:08 2016 (r310231) > +++ head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c Sun Dec 18 15:21:38 2016 (r310232) > @@ -79,7 +79,7 @@ static ssize_t store_admin_alias_guid(st > container_of(attr, struct mlx4_ib_iov_sysfs_attr, dentry); > struct mlx4_ib_iov_port *port = mlx4_ib_iov_dentry->ctx; > struct mlx4_ib_dev *mdev = port->dev; > - u64 sysadmin_ag_val; > + unsigned long long sysadmin_ag_val; > > record_num = mlx4_ib_iov_dentry->entry_num / 8; > guid_index_in_rec = mlx4_ib_iov_dentry->entry_num % 8; > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9290641f-00e0-4091-e641-448d2d0d24d6>