Date: Sun, 28 Apr 2024 14:37:48 +0200 From: Mateusz Piotrowski <0mp@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 5626f9e79090 - main - style.9: Document the existence of tools/build/checkstyle9.pl Message-ID: <026867C8-33DC-4555-8B6B-03E0E848510D@FreeBSD.org> In-Reply-To: <CANCZdfokbfo8UsHJL98ZV6jDCKtQS6eFM6-7SJy4t_N2CLpDiA@mail.gmail.com> References: <202404260938.43Q9cSwG055237@gitrepo.freebsd.org> <CANCZdfokbfo8UsHJL98ZV6jDCKtQS6eFM6-7SJy4t_N2CLpDiA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hey Warner, Thanks for taking a look at the patch! > On 26. Apr 2024, at 15:30, Warner Losh <imp@bsdimp.com> wrote: > On Fri, Apr 26, 2024, 3:38 AM Mateusz Piotrowski <0mp@freebsd.org <mailto:0mp@freebsd.org>> wrote: >> The branch main has been updated by 0mp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=5626f9e790901999def12040a60746b0ceeb9b95 <https://cgit.freebsd.org/src/commit/?id=5626f9e790901999def12040a60746b0ceeb9b95>; [...] >> >> style.9: Document the existence of tools/build/checkstyle9.pl <http://checkstyle9.pl/>; [...] >> share/man/man9/style.9 | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) [...] >> @@ -904,6 +904,10 @@ instead of the older >> .Fn CTASSERT . >> .Sh FILES >> .Bl -tag -width indent >> +.It Pa /usr/src/tools/build/checkstyle9.pl <http://checkstyle9.pl/>; >> +A script to check for violations of > > > Egregious violations and there are some false positives still. checkstyle9 is already warning against those imperfections. I assumed that there is no need to warn against those in the manual page as well. I can add additional disclaimers if you think they are desired :) Best, Mateusz Piotrowski [-- Attachment #2 --] <html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">Hey Warner,<div><br></div><div>Thanks for taking a look at the patch!<br id="lineBreakAtBeginningOfMessage"><div><br><blockquote type="cite"><div>On 26. Apr 2024, at 15:30, Warner Losh <imp@bsdimp.com> wrote:</div><div><div dir="auto" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 26, 2024, 3:38 AM Mateusz Piotrowski <<a href="mailto:0mp@freebsd.org">0mp@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">The branch main has been updated by 0mp:<br><br>URL:<span class="Apple-converted-space"> </span><a href="https://cgit.freebsd.org/src/commit/?id=5626f9e790901999def12040a60746b0ceeb9b95" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=5626f9e790901999def12040a60746b0ceeb9b95</a><br></blockquote></div></div></div></div></blockquote>[...]<br><blockquote type="cite"><div><div dir="auto" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><br> <span class="Apple-converted-space"> </span>style.9: Document the existence of tools/build/<a href="http://checkstyle9.pl/" rel="noreferrer noreferrer" target="_blank">checkstyle9.pl</a><br></blockquote></div></div></div></div></blockquote>[...]<br><blockquote type="cite"><div><div dir="auto" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"> share/man/man9/style.9 | 6 +++++-<br> 1 file changed, 5 insertions(+), 1 deletion(-)<br></blockquote></div></div></div></div></blockquote>[...]<br><blockquote type="cite"><div><div dir="auto" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">@@ -904,6 +904,10 @@ instead of the older<br> .Fn CTASSERT .<br> .Sh FILES<br> .Bl -tag -width indent<br>+.It Pa /usr/src/tools/build/<a href="http://checkstyle9.pl/" rel="noreferrer noreferrer" target="_blank">checkstyle9.pl</a><br>+A script to check for violations of<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Egregious violations and there are some false positives still.</div></div></div></blockquote><br></div><div>checkstyle9 is already warning against those imperfections. I assumed that there is no need to warn against those in the manual page as well. I can add additional disclaimers if you think they are desired :)</div><div><br></div><div>Best,</div><div>Mateusz Piotrowski</div><br></div></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?026867C8-33DC-4555-8B6B-03E0E848510D>