Date: Mon, 24 Apr 2023 22:18:01 +0200 From: Moin Rahman <bofh@freebsd.org> To: Antoine Brodin <antoine@freebsd.org> Cc: "<ports-committers@freebsd.org>" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 9f5034f55a47 - main - Mk/Uses/php.mk: Refactor Message-ID: <F288BA3E-070A-4D83-A445-CB450B938024@freebsd.org> In-Reply-To: <CAALwa8k6J%2Bc3KWuc1o_h9ZLCUf9xiZRpU4EMMM0MyVhzKfUO%2Bw@mail.gmail.com> References: <202304242001.33OK19wU009301@gitrepo.freebsd.org> <CAALwa8k6J%2Bc3KWuc1o_h9ZLCUf9xiZRpU4EMMM0MyVhzKfUO%2Bw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Apr 24, 2023, at 10:16 PM, Antoine Brodin <antoine@freebsd.org> wrote: > > On Mon, Apr 24, 2023 at 8:01 PM Muhammad Moinur Rahman <bofh@freebsd.org <mailto:bofh@freebsd.org>> wrote: >> >> The branch main has been updated by bofh: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=9f5034f55a47591288167cd49fe4bb963143caed >> >> commit 9f5034f55a47591288167cd49fe4bb963143caed >> Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> >> AuthorDate: 2023-04-24 19:59:31 +0000 >> Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> >> CommitDate: 2023-04-24 20:01:01 +0000 >> >> Mk/Uses/php.mk: Refactor >> >> - Replace old USE_APACHE_RUN with USES=apache:run >> - Prior to php8.0 there was a check for the required libname which >> contained the version number of php. Remove the conditional. >> >> Sponsored by: Bounce Experts >> --- >> Mk/Uses/php.mk | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) > > Hi, > > Overriding USES doesn't look good. > Maybe it should be something like this instead: > apache_ARGS?=run > .include "${USESDIR}/apache.mk" > > Antoine Ouch. Let me rerun a test and update. Kind regards, Moin [-- Attachment #2 --] <html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 24, 2023, at 10:16 PM, Antoine Brodin <<a href="mailto:antoine@freebsd.org" class="">antoine@freebsd.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><span style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On Mon, Apr 24, 2023 at 8:01 PM Muhammad Moinur Rahman <</span><a href="mailto:bofh@freebsd.org" style="font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">bofh@freebsd.org</a><span style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">> wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class="">The branch main has been updated by bofh:<br class=""><br class="">URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=9f5034f55a47591288167cd49fe4bb963143caed" class="">https://cgit.FreeBSD.org/ports/commit/?id=9f5034f55a47591288167cd49fe4bb963143caed</a><br class=""><br class="">commit 9f5034f55a47591288167cd49fe4bb963143caed<br class="">Author: Muhammad Moinur Rahman <<a href="mailto:bofh@FreeBSD.org" class="">bofh@FreeBSD.org</a>><br class="">AuthorDate: 2023-04-24 19:59:31 +0000<br class="">Commit: Muhammad Moinur Rahman <<a href="mailto:bofh@FreeBSD.org" class="">bofh@FreeBSD.org</a>><br class="">CommitDate: 2023-04-24 20:01:01 +0000<br class=""><br class=""> Mk/Uses/php.mk: Refactor<br class=""><br class=""> - Replace old USE_APACHE_RUN with USES=apache:run<br class=""> - Prior to php8.0 there was a check for the required libname which<br class=""> contained the version number of php. Remove the conditional.<br class=""><br class=""> Sponsored by: Bounce Experts<br class="">---<br class="">Mk/Uses/php.mk | 7 +------<br class="">1 file changed, 1 insertion(+), 6 deletions(-)<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Hi,</span><br style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Overriding USES doesn't look good.</span><br style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Maybe it should be something like this instead:</span><br style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">apache_ARGS?=run</span><br style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">.include "${USESDIR}/apache.mk"</span><br style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Antoine</span></div></blockquote></div><br class=""><div class=""><br class=""></div><div class="">Ouch. Let me rerun a test and update.</div><div class=""><br class=""></div><div class="">Kind regards,</div><div class="">Moin</div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F288BA3E-070A-4D83-A445-CB450B938024>