Date: Sat, 19 May 2012 16:40:05 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Robert Millan <rmh@freebsd.org> Cc: freebsd-arch@freebsd.org Subject: Re: headers that use "struct bintime" Message-ID: <20120519134005.GJ2358@deviant.kiev.zoral.com.ua> In-Reply-To: <CAOfDtXPidEVGHDeZWTQyk-X6pabc0HBqWLdNJG_zRgX=7iKgWg@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Sat, May 19, 2012 at 03:33:03PM +0200, Robert Millan wrote: > "struct bintime" is enabled only by __BSD_VISIBLE. However, there are > a few headers that use "struct bintime" without __BSD_VISIBLE: > > sys/arm/include/cpu.h > sys/dev/iscsi/initiator/iscsivar.h > sys/geom/journal/g_journal.h > sys/sys/dtrace_bsd.h > sys/sys/devicestat.h > sys/sys/timeet.h > sys/sys/bio.h > sys/opencrypto/cryptodev.h > > Should the definitions that use "struct bintime" be __BSD_VISIBLE too? > Or maybe "struct bintime" be defined unconditionally? > > Or perhaps we could have "struct __bintime" and use that for system headers? Note that all headers you listed are kernel headers, and kernel is exposed to the whole namespace. I suspect that no headers are supposed to be used by usermode among the list. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+3orUACgkQC3+MBN1Mb4htWwCeJV9AuH/VdC4OzaZlZSxg8cx8 vAkAnRG0joEKCMYHhJpai0ROGv79nXUQ =5ZIi -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120519134005.GJ2358>