Date: Thu, 25 Jan 2018 11:16:23 +1100 From: "Kristof Provost" <kp@FreeBSD.org> To: "Gleb Smirnoff" <glebius@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328313 - head/sys/netpfil/pf Message-ID: <F461DD1E-DBA0-4E5B-8725-FE1ED775F9AB@FreeBSD.org> In-Reply-To: <20180125001310.GJ8113@FreeBSD.org> References: <201801240429.w0O4THIl059440@repo.freebsd.org> <20180125001310.GJ8113@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 Jan 2018, at 11:13, Gleb Smirnoff wrote: > On Wed, Jan 24, 2018 at 04:29:17AM +0000, Kristof Provost wrote: > K> Author: kp > K> Date: Wed Jan 24 04:29:16 2018 > K> New Revision: 328313 > K> URL: https://svnweb.freebsd.org/changeset/base/328313 > K> > K> Log: > K> pf: States have at least two references > K> > K> pf_unlink_state() releases a reference to the state without > checking if > K> this is the last reference. It can't be, because > pf_state_insert() > K> initialises it to two. KASSERT() that this is always the case. > K> > K> CID: 1347140 > K> > K> + last = refcount_release(&s->refs); > K> + KASSERT(last == 0, ("Incorrect state reference count")); > K> > K> return (pf_release_state(s)); > K> } > > IMHO, we shouldn't emit extra code to please Coverity. We can mark it > as a false positive in the interface. It may make sense to add a > comment > for a human to explain why return isn't checked here. > I find the KASSERT() to be a good way of verifying that this assumption is in fact correct. You do have a good point about the comment. Regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F461DD1E-DBA0-4E5B-8725-FE1ED775F9AB>