Date: Thu, 3 Mar 2016 13:29:57 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Konstantin Belousov <kib@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296320 - in head/sys: kern sys Message-ID: <56D82E45.3090205@selasky.org> In-Reply-To: <201603021846.u22IkHWM010861@repo.freebsd.org> References: <201603021846.u22IkHWM010861@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/02/16 19:46, Konstantin Belousov wrote:
> Modified: head/sys/kern/subr_sleepqueue.c
> ==============================================================================
> --- head/sys/kern/subr_sleepqueue.c Wed Mar 2 16:36:24 2016 (r296319)
> +++ head/sys/kern/subr_sleepqueue.c Wed Mar 2 18:46:17 2016 (r296320)
> @@ -586,7 +586,8 @@ sleepq_check_timeout(void)
> * another CPU, so synchronize with it to avoid having it
> * accidentally wake up a subsequent sleep.
> */
> - else if (callout_stop(&td->td_slpcallout) == 0) {
> + else if (_callout_stop_safe(&td->td_slpcallout, CS_MIGRBLOCK, NULL)
> + == 0) {
> td->td_flags |= TDF_TIMEOUT;
> TD_SET_SLEEPING(td);
> mi_switch(SW_INVOL | SWT_SLEEPQTIMO, NULL);
The "td_slpcallout" is not drained anywhere, last time I checked. Does
this change require draining of the td_slpcallout in case the thread
immediately is exited/destroyed?
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56D82E45.3090205>