Date: Tue, 30 Jan 2018 18:49:57 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-virtualization@FreeBSD.org Subject: [Bug 225558] [bhyve][patch] Add option to specify emulated NIC in vmrun.sh Message-ID: <bug-225558-27103-8aLAkSXfwZ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-225558-27103@https.bugs.freebsd.org/bugzilla/> References: <bug-225558-27103@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225558 Rodney W. Grimes <rgrimes@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rgrimes@FreeBSD.org --- Comment #2 from Rodney W. Grimes <rgrimes@FreeBSD.org> --- First pass look at this patch leads to these comments: White space change at line 40, this change should not be made -n option added out of alpha order at line 74, should be after -m, "ethernet adapter" is a little vague and missleading, this is actually "network adapter emulation type" I am not sure how much should be added to vmrun.sh, this was suppose to be a simple script for simple operations, if your getting complicated you should be invoking bhyve, not vmrun, the only other valid option for -n at this time is e1000, is it really worth adding a knob to vmrun.sh to switch between virtio-net and e1000? Or even if we consider the ne2000 out of tree code, that is a 3 way option. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-225558-27103-8aLAkSXfwZ>