Date: Thu, 06 Apr 2000 03:21:19 +0900 From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org> To: imp@village.org Cc: iwasaki@jp.freebsd.org, freebsd-mobile@FreeBSD.ORG Subject: Re: Call for review: Wildcard entry support Message-ID: <200004051821.DAA16021@tasogare.imasy.or.jp> In-Reply-To: Your message of "Tue, 04 Apr 2000 03:19:36 %2B0900" <200004031819.DAA11822@tasogare.imasy.or.jp> References: <200004031819.DAA11822@tasogare.imasy.or.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, > > : I think it is better to have them because more than two available > > : config lines are needed if two cards use the same generic entry. > > : Also, I'm expecting that a lot of normal cards can be supported by > > : generic entries and this will cause few new card to be added. > > : In this case, the `just in case' entries make sense. > > > > Does the generic entry give you one of the cards, unspecified in > > number, or does it give you an unlimited number of them. If the form, > > I can see why you'd want to have more just in case. If the latter, > > then I don't see the point. If the generic code can eliminate a large > > number of entries (say all of the modems), then having a couple of > > extra lines shouldn't be a huge deal. They seem like they might be > > nops to me, which is why I ask. > > I was expecting the latter but actual code seems to say the former. > Currently generic entry can support only one card at the same time, > so the extra lines make sense only if the same type of card (but > different card) uses the same configuraion. Changing 2 lines of > conf->inuse = 1; > to > if (cp->func_id == 0) > conf->inuse = 1; > in cardd.c is my expected behavior, an unlimited number of cards can > share one generic entry using different configuration for each cards. Sorry for my misunderstanding, no additional code is needed for this. OK, I'll remove 'just in case' config line from pccard.conf and commit them first. I'll improve this feature later If there is an opportunity. Thanks To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200004051821.DAA16021>