Date: Thu, 21 Nov 2019 16:13:37 +0000 From: Glen Barber <gjb@freebsd.org> To: Brooks Davis <brooks@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, FreeBSD Ports Management Team <portmgr@freebsd.org>, Colin Percival <cperciva@freebsd.org> Subject: Re: svn commit: r354909 - in head: . share/mk Message-ID: <20191121161337.GA92849@FreeBSD.org> In-Reply-To: <201911201836.xAKIawWt053874@repo.freebsd.org> References: <201911201836.xAKIawWt053874@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 20, 2019 at 06:36:58PM +0000, Brooks Davis wrote: > Author: brooks > Date: Wed Nov 20 18:36:58 2019 > New Revision: 354909 > URL: https://svnweb.freebsd.org/changeset/base/354909 >=20 > Log: > Make the warning for deprecated NO_ variables an error. > =20 > Support for NO_CTF, NO_DEBUG_FILES, NO_INSTALLLIB, NO_MAN, NO_PROFILE, > and NO_WARNS as deprecated in 2014 with a warning added for each one > found. Turn these into error in preperation for removal of compatability > support before FreeBSD 13. > =20 > Reviewed by: imp > Relnotes: yes > Sponsored by: DARPA, AFRL > Differential Revision: https://reviews.freebsd.org/D22448 >=20 > Modified: head/share/mk/bsd.opts.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/share/mk/bsd.opts.mk Wed Nov 20 18:12:01 2019 (r354908) > +++ head/share/mk/bsd.opts.mk Wed Nov 20 18:36:58 2019 (r354909) > @@ -100,7 +100,7 @@ __DEFAULT_DEPENDENT_OPTIONS =3D \ > PROFILE \ > WARNS > .if defined(NO_${var}) > -.warning "NO_${var} is defined, but deprecated. Please use MK_${var}=3Dn= o instead." > +.error "NO_${var} is defined, but deprecated. Please use MK_${var}=3Dno = instead." > MK_${var}:=3Dno > .endif > .endfor >=20 Had this been exp-run tested? This breaks at least the net/bsdec2-image-upload port, which does *not* set NO_MAN explicitly in its Makefile. I suspect at least several other ports are now implicitly broken as result of this change. Glen --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAl3Wt7EACgkQAxRYpUeP 4pOTuxAAgR2/yJghO5rzYZCSvcCFD7Hk30IH0ECYsahxcXH8q90WWKTAmSUQCwqU n3V9oFygnyLCpXEcQRlSsrvCRgcW0K6C0UCA4zsOftCWh5qoLP6B0k6bZvUI4Bqp d4XagrBxerRro0pZgwQ5x3jie3SylkfwwMvbmy9zHL21jca24AwF4GfwvV5ksB0a AKF812J5iH+LRJAca2OJumNyA7vz3QbZJurCi/0WQLaij4vcbKIl5TK/lqkrcru+ sgAFhhaE79y9UDp8eNugUeR7/0/gy6KuHcqQJ+A50DMwHM1jvAw9L476UsRInNs6 jDKNDLY0ujEBAt8jNAWsL18vmk+KUcvOqbkkxG6Uz8rDt8iE7tjF4M9n5GgLv/gP tykkNY2InwCdo0SX3+1QiUSFCv37MRlb5OSLHK0P1gsBwKxbgLBuj6l01c8Pyl7G nWR+akbaLm9w1e1FZ5SaA+Gb/kNwq6Jv1ck4Pm+iem7Z5gwG3ITRKkNsBu97Mowh rCaSv+XnwxRKLBFHd9y1G2GhNmkMLrVav/qNYVxSt0CcT8aI9A+4JKxZC6j9TLzb Nqr9zh9KjYyoABHJhpIWLu9quyqqcaMekE0v8ddklED0UffOAen+IIOpZrvpdNd+ UW8QoNwbsndpZJJfYZhpxNr5i7p3Kh2gZqeiUKoPe774tYP5qXQ= =d3mA -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191121161337.GA92849>