Date: Thu, 18 Sep 2008 10:28:08 GMT From: Sergey Skvortsov <godegisel@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/127467: bsd.ports.mk: fix checking DISTDIR for writeability Message-ID: <200809181028.m8IAS8eX017144@freefall.freebsd.org> Resent-Message-ID: <200809181030.m8IAU1l4017177@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 127467
>Category: ports
>Synopsis: bsd.ports.mk: fix checking DISTDIR for writeability
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Sep 18 10:30:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Sergey Skvortsov
>Release: FreeBSD 7.1-PRERELEASE i386
>Organization:
>Environment:
>Description:
>How-To-Repeat:
# run as unprivileged user in 'wheel' group
sudo chmod g+w /usr/ports/distfiles/vim
cd /usr/ports/editors/vim-lite
make fetch
[skip]
=> vim-7.2.tar.bz2 doesn't seem to exist in /usr/ports/distfiles/vim.
=> /usr/ports/distfiles is not writable by you; cannot fetch.
>Fix:
Check real dir, not the parent.
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.604
diff -u -r1.604 bsd.port.mk
--- bsd.port.mk 5 Sep 2008 19:41:43 -0000 1.604
+++ bsd.port.mk 18 Sep 2008 09:26:54 -0000
@@ -3413,8 +3413,8 @@
fi; \
fi; \
${ECHO_MSG} "=> $$file doesn't seem to exist in ${_DISTDIR}."; \
- if [ ! -w ${DISTDIR} ]; then \
- ${ECHO_MSG} "=> ${DISTDIR} is not writable by you; cannot fetch."; \
+ if [ ! -w ${_DISTDIR} ]; then \
+ ${ECHO_MSG} "=> ${_DISTDIR} is not writable by you; cannot fetch."; \
exit 1; \
fi; \
if [ ! -z "$$select" ] ; then \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809181028.m8IAS8eX017144>