Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Dec 2009 16:32:23 -0800
From:      Doug Barton <dougb@FreeBSD.org>
To:        "Philip M. Gollucci" <pgollucci@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, yaizawa@2004.jukuin.keio.ac.jp, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/mail/quickml/files quickml.in
Message-ID:  <4B2ACD97.903@FreeBSD.org>
In-Reply-To: <4B2ACCC2.4060703@FreeBSD.org>
References:  <200912172324.nBHNOPlD073719@repoman.freebsd.org> <4B2ACCC2.4060703@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
Doug Barton wrote:
> This script is missing several things, including PROVIDE/REQUIRE and
> at minimum a default for _enable.

... and KEYWORD: shutdown, since it starts a service. New patch attached.

> I also believe (although I have not
> tested it) that command_interpreter should be set rather than using
> command=ruby and command_args the way that it was.
> 
> The attached patch fixes these issues, although the command stuff
> should be tested.
> 
> 
> Doug
> 
> 
> Philip M. Gollucci wrote:
>> pgollucci    2009-12-17 23:24:25 UTC
>>
>>   FreeBSD ports repository
>>
>>   Added files:
>>     mail/quickml/files   quickml.in 
>>   Log:
>>   - missed the rc.d file
>>   
>>   Revision  Changes    Path
>>   1.1       +18 -0     ports/mail/quickml/files/quickml.in (new)
>>
>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/quickml/files/quickml.in
>>
> 
> 


-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/


[-- Attachment #2 --]
Index: quickml.in
===================================================================
RCS file: /home/pcvs/ports/mail/quickml/files/quickml.in,v
retrieving revision 1.1
diff -u -r1.1 quickml.in
--- quickml.in	17 Dec 2009 23:24:25 -0000	1.1
+++ quickml.in	18 Dec 2009 00:31:29 -0000
@@ -3,16 +3,27 @@
 # $FreeBSD: ports/mail/quickml/files/quickml.in,v 1.1 2009/12/17 23:24:25 pgollucci Exp $
 #
 
-. %%RC_SUBR%%
+# PROVIDE: quickml
+# REQUIRE: LOGIN
+# KEYWORD: shutdown
+#
+# Add the following lines to /etc/rc.conf.local or /etc/rc.conf
+# to enable this service:
+#
+# quickml_enable (bool):	Set to NO by default.
+
+. /etc/rc.subr
 
 name="quickml"
 rcvar=`set_rcvar`
 
-command="%%RUBY%%"
-command_args="%%PREFIX%%/sbin/${name}"
+command="%%PREFIX%%/sbin/${name}"
+command_interpreter="%%RUBY%%"
 pidfile="/var/run/${name}.pid"
 required_files=%%PREFIX%%/etc/quickmlrc
 
 load_rc_config $name
 
+: ${quickml_enable="NO"}
+
 run_rc_command "$1"
help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B2ACD97.903>